AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

FIT: add RecPoint reader and writer workflows for FV0 and FDD

Open andreasmolander opened this issue 1 year ago • 9 comments

The main purpose of the commit:

  • Adding workflows for reading RecPoints for FV0 and FDD, these are needed for MC aQC

Secondary purposes that arose during development:

  • ROOT macro for comparing two RecPoint files
  • Workflows for writing RecPoints added for FT0, FV0 and FDD (i.e. simply standalone RecPoint writers, not related to reconstrucion)
  • The two items above were needed to verify the new RecPoint reader workflows, namely by: reconstructing CTFs -> writing RecPoints to file -> Reading RecPoints from file -> Writing RecPoints to new file -> Comparing the two files
  • Minor cosmetics (e.g. reordering of includes) and utility functions (print and == operator functions)

andreasmolander avatar Sep 04 '24 13:09 andreasmolander

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass3 async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0

github-actions[bot] avatar Sep 04 '24 13:09 github-actions[bot]

+async-label async-2024-pbpb-apass4, async-2024-pp-apass7, async-2023-pbpb-apass3, async-2023-pp-apass4

andreasmolander avatar Sep 04 '24 13:09 andreasmolander

Hi @andreasmolander, the following label names could not be recognised: async-2024-pbpb-apass4, async-2024-pp-apass7

github-actions[bot] avatar Sep 04 '24 13:09 github-actions[bot]

+async-label async-2024-pp-apass1, async-2022-pp-apass7, async-2023-pp-apass4

andreasmolander avatar Sep 04 '24 14:09 andreasmolander

+async-label async-2023-pbpb-apass4

andreasmolander avatar Sep 04 '24 14:09 andreasmolander

Error while checking build/O2/fullCI for 768f585f6a38b3a47e1e94017a2e46ba72b7f784 at 2024-09-07 18:07:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1149:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTrackingWorkflow/src/TOFMatchChecker.cxx:108:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild avatar Sep 06 '24 16:09 alibuild

Error while checking build/O2/fullCI for 692e0f287e6d2670f383efdd7706d1d2167ec23f at 2024-09-15 11:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTrackingWorkflow/src/TOFMatchChecker.cxx:108:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1150:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
/sw/SOURCES/O2/13482-slc8_x86-64/0/EventVisualisation/Workflow/src/EveWorkflowHelper.cxx:898:16: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild avatar Sep 10 '24 12:09 alibuild

Error while checking build/O2/fullCI for 6b9b7a643375db6711877a566b76d30497829e23 at 2024-09-20 22:26:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

alibuild avatar Sep 20 '24 20:09 alibuild

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Oct 27 '24 01:10 github-actions[bot]

+async-label !async-2022-pp-apass7, !async-2023-pbpb-apass4, !async-2023-pp-apass4, !async-2024-pp-apass1

andreasmolander avatar Feb 18 '25 13:02 andreasmolander