FVD detector
Software model for future FV0 like detector consisting of two segmented scintillator disks.
REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-
+async-label <label1>, <label2>, !<label3> ...
This will add <label1> and <label2> and removes <label3>.
The following labels are available async-2023-pbpb-apass3 async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0
Software model for future FV0 like detector consisting of two segmented scintillator disks.
Looks reasonably good to me, I will find the time to test it locally. Thanks!
Error while checking build/O2/fullCI_slc9 for c7bf68d9cd8cf7b10122b211a92eecd398f7280d at 2025-01-29 10:39:
## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/base/src/GeometryTGeo.cxx:37:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:368:15: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:381:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:383:9: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--
Full log here.
Error while checking build/O2/fullCI for c7bf68d9cd8cf7b10122b211a92eecd398f7280d at 2025-01-29 12:05:
## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/base/src/GeometryTGeo.cxx:37:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:368:15: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:381:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:383:9: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--
Full log here.
Error while checking build/O2/fullCI_slc9 for 96ad811b321d86aac681c47c16b78ba35339d7af at 2025-02-02 16:19:
++ cp /sw/slc9_x86-64/O2/13476-slc9_x86-64-local2/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonprefix([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/13476-slc9_x86-64/0/
++ [[ -e /sw/SOURCES/O2/13476-slc9_x86-64/0//CMakeLists.txt ]]
Full log here.
Error while checking build/O2/fullCI for 96ad811b321d86aac681c47c16b78ba35339d7af at 2025-02-02 16:35:
## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
Full log here.
Error while checking build/O2/fullCI for c19814f2cd79b860333849e44012235bf6300ede at 2025-02-05 10:27:
## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[28030:internal-dpl-ccdb-backend]: [09:27:32][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] CCDBDownloader CURL transfer error - Unsupported protocol
[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Param/MatLUT/1546300800000/3f0d0f81-99d9-11ee-b9a2-200114580202 for 1550600800000 (agent_id: alimetal09.cern.ch-1738747647-76RLRZ) with http code: 0
[28030:internal-dpl-ccdb-backend]: [09:27:32][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] Exception while running: Fatal error. Rethrowing.
[28030:internal-dpl-ccdb-backend]: [09:27:32][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 28030 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] - Device internal-dpl-ccdb-backend: pid 28030 (exit 128)
[INFO] - First error: [09:27:32][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (28030) had at least one message above severity 5: Unable to find object GLO/Param/MatLUT/1550600800000
## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/5c490f77479e703dea39788684109b5c1416bcf8/slc8_x86-64/o2checkcode/1.0-local68/etc/modulefiles
++ cat
--
Full log here.
Error while checking build/O2/fullCI_slc9 for c19814f2cd79b860333849e44012235bf6300ede at 2025-02-05 10:47:
## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile tpcreco.log
./sim-challenge.logtpcreco.log:[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logtpcreco.log-[8330:internal-dpl-ccdb-backend]: [10:47:12][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] CCDBDownloader CURL transfer error - Unsupported protocol
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Param/MatLUT/1546300800000/3f0d0f81-99d9-11ee-b9a2-200114580202 for 1546300800000 (agent_id: alimetal04.cern.ch-1738748829-0eGPHh) with http code: 0
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][FATAL] Unable to find object GLO/Param/MatLUT/1546300800000
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 8330 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR] - Device internal-dpl-ccdb-backend: pid 8330 (exit 128)
./sim-challenge.log[INFO] - First error: [10:47:12][FATAL] Unable to find object GLO/Param/MatLUT/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (8330) had at least one message above severity 5: Unable to find object GLO/Param/MatLUT/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5772:TPCDigitizer_3]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
[0 more errors; see full log]
Full log here.
Hi @pkurash, what is the status of this? I see some spurious and empty files added, also not really related to the FD implementation (e.g. GPU stuff). Could you please rebase this to dev and cleanup the empty/unrelated files?
Then I think this can be merged.
Hi @pkurash, Could you rebase your branch?
Error while checking build/O2/fullCI_slc9 for e451741a9841d6b6254cb7e3a4ccd1a814afcccb at 2025-03-27 01:21:
## sw/BUILD/O2-RTC-test-latest/log
clang++: error: unknown argument: '-mdaz-ftz'
clang++: error: unknown argument: '-mdaz-ftz'
clang++: error: unknown argument: '-mdaz-ftz'
clang++: error: unknown argument: '-mdaz-ftz'
## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/bc285fb1b39f748fbcb26d009443e99437debf2b/slc9_x86-64/o2checkcode/1.0-local5/etc/modulefiles
++ cat
--
Full log here.
Error while checking build/O2/fullCI_slc9 for 632173516bdbf6dec2ae7b71f1f52eb850ec4f96 at 2025-03-28 17:56:
## sw/BUILD/O2-latest/log
CMake Error at cmake/O2RootMacroExclusionList.cmake:87 (message):
Full log here.
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.
Error while checking build/O2/fullCI_slc9 for 180fecca58a743d8cbf9b018812f39db7f851f22 at 2025-07-09 00:46:
## sw/BUILD/db8475324e7cded41856de40fc6b695bd2e2e2fc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1
Full log here.
Error while checking build/O2/fullCI_slc9 for 914e9294ee99ec700ce299d80013f1cc746dacda at 2025-07-10 12:21:
## sw/BUILD/4ca51307b106213ce7ad18dea3427170d8d6aafc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1
Full log here.
Error while checking build/O2/fullCI_slc9 for 0b61e9ae53599b8ac02fc5918fcee282d5458614 at 2025-07-15 18:02:
No log files found
Full log here.
Error while checking build/O2/fullCI_slc9 for 4d834d7af7a06f48a3666e2f65b1c431fb11a277 at 2025-08-06 11:15:
++ cp /sw/slc9_x86-64/O2/13476-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/13476-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/13476-slc9_x86-64/0/CMakeLists.txt ]]
Full log here.
Error while checking build/O2/fullCI_slc9 for b1ca536af46e6d151ca0d651a71704cfd4893a99 at 2025-09-05 11:20:
## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/156c130ad38ef2f530d51cc5d8b56b7cd1e09bb9/slc9_x86-64/o2checkcode/1.0-local264/etc/modulefiles
++ cat
--
Full log here.
Error while checking build/O2/fullCI_slc9 for b84fdbd956c87c0403b4b9c6a4035d85ee33c976 at 2025-09-11 00:39:
No log files found
Full log here.
Error while checking build/O2/fullCI_slc9 for 21545f8e59b00fb1a7efe0718ca36c8ac0373702 at 2025-09-16 13:27:
No log files found
Full log here.
Error while checking build/O2/fullCI_slc9 for dc31a81b8d1db139873ec3fc927967c7dbb61da0 at 2025-09-21 15:23:
++ cp /sw/slc9_x86-64/O2/13476-slc9_x86-64-local3/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/13476-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/13476-slc9_x86-64/0/CMakeLists.txt ]]
Full log here.
Error while checking build/O2/fullCI_slc9 for 5162f297254ea49c3e0d768cf67dc5138fd01684 at 2025-09-27 05:00:
## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep ' error:'
++ grep -v clang-diagnostic-error error-log.txt
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/ECal/simulation/src/Detector.cxx:361:17: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--
Full log here.
Error while checking build/O2/fullCI_slc9 for 303c84f13043d009f87d8abc0a599827b1311612 at 2025-10-08 02:59:
No log files found
Full log here.
Hello Nicolo,
I was going to switch to the three letter notation, just kept it for the sake of my simulation which used two-letter detector name and namespaces. I also like your idea of the name, will try to make the change as soon as possible
Regards, Podist
On Wed, 2025-10-08 at 07:49 -0700, Nicolò Jacazio wrote:
@njacazio commented on this pull request.
In Common/SimConfig/src/SimConfig.cxxhttps://github.com/AliceO2Group/AliceO2/pull/13476#discussion_r2414125378:
@@ -98,7 +98,8 @@ void SimConfig::determineActiveModules(std::vectorstd::string const& inputargs
activeModules[i] != "TF3" &&
activeModules[i] != "RCH" &&
activeModules[i] != "MI3" &&
-
activeModules[i] != "ECL") {
-
activeModules[i] != "ECL" && -
activeModules[i] != "FD") {
Hi @pkurashhttps://github.com/pkurash we should stick to the 3 letter nomenclature, how about FD3?
— Reply to this email directly, view it on GitHubhttps://github.com/AliceO2Group/AliceO2/pull/13476#pullrequestreview-3315206201, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETLCRCVZTKRBPRHATHANBL3WUP7NAVCNFSM6AAAAABNTVHVBGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJVGIYDMMRQGE. You are receiving this because you were mentioned.Message ID: @.***>
Ciao @pkurash I think we can merge this if you're ready
Ciao @pkurash I think we can merge this if you're ready
Hello, yes, I think it is ready to be merged.
Ciao @shahor02 could you please re-review the PR? Many thanks!
Error while checking build/O2/fullCI_slc9 for d893b69a6785ab72fb74766f9dd28f31e34b9c45 at 2025-10-20 12:48:
## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
[0 more errors; see full log]
Full log here.
@mconcas @shahor02 could this be merged?
Thanks!