AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

POD version of TPCFastSpaceChargeCorrection

Open shahor02 opened this issue 1 year ago • 3 comments

Created from the TPCFastTransform using:

std::vector<char> buff; // can be also pmr::vector from DPL make(..) const o2::gpu::TPCFastTransformPOD& pod = o2::gpu::TPCFastTransformPOD::create(buff, tpc_fast_transform);

The buff vector will be expanded during creation and can be sent over DPL. On the receiving side, it should be cast as:

const auto& podTransform = o2::gpu::TPCFastTransformPOD::get(pc.inputs().get<gsl::span<char>>(ref));

No initialization is needed, the transform methods (at the moment all methods of TPCFastSpaceChargeCorrection are implemented) can be directly queried from the object received over sh.memory.

shahor02 avatar Jul 16 '24 23:07 shahor02

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass3 async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0

github-actions[bot] avatar Jul 16 '24 23:07 github-actions[bot]

Error while checking build/O2/fullCI for 73187e41f94b2c7c5d56fc6243234caceff5c012 at 2025-01-16 05:20:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[33300:internal-dpl-ccdb-backend]: [04:20:22][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[33300:internal-dpl-ccdb-backend]: [04:20:22][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[33300:internal-dpl-ccdb-backend]: [04:20:22][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[33300:internal-dpl-ccdb-backend]: [04:20:22][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/PHS/Calib/CTFDictionaryTree for 1550600800000 (agent_id: alimetal02.cern.ch-1737001189-brcQPY) with http code: 0
[33300:internal-dpl-ccdb-backend]: [04:20:22][ERROR] File PHS/Calib/CTFDictionaryTree could not be retrieved. No more hosts to try.
[33300:internal-dpl-ccdb-backend]: [04:20:22][FATAL] Unable to find object PHS/Calib/CTFDictionaryTree/1550600800000
[33300:internal-dpl-ccdb-backend]: [04:20:22][ERROR] Exception while running: Fatal error. Rethrowing.
[33300:internal-dpl-ccdb-backend]: [04:20:22][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 33300 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 33300 (exit 128)
[INFO]    - First error: [04:20:22][FATAL] Unable to find object PHS/Calib/CTFDictionaryTree/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (33300) had at least one message above severity 5: Unable to find object PHS/Calib/CTFDictionaryTree/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/bb644fe67f13131da52eff6505c86b9260206d89/slc8_x86-64/o2checkcode/1.0-local18/etc/modulefiles
++ cat
--

Full log here.

alibuild avatar Jul 24 '24 02:07 alibuild

Error while checking build/O2/fullCI for 704db4164d4981850a63c8059e9540e0dd539e73 at 2024-09-25 14:44:

## sw/BUILD/Rivet-latest/log
make[2]: *** [Makefile:544: core.cpp] Error 127
make[1]: *** [Makefile:440: all-recursive] Error 1
make: *** [Makefile:561: all-recursive] Error 1

Full log here.

alibuild avatar Sep 09 '24 07:09 alibuild

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Nov 23 '24 01:11 github-actions[bot]

Commenting to avoid closure

shahor02 avatar Nov 23 '24 01:11 shahor02

ok then, I don't mind. we can merge it.

davidrohr avatar Nov 24 '24 16:11 davidrohr

It will likely conflict with the next commit from @sgorbuno and with the current TPCFastTransform we are anyway not going to use it. Should not we wait for the summable TPCFastTransform?

shahor02 avatar Nov 24 '24 17:11 shahor02

@sgorbuno : This is Ruben's class for the in-memory flat representation of the TPC transformation without pointers. From my side this looks good. Could you have a look? Would you prefer that we merge this as is, or shall we wait for further changes to TPCFastTransform?

davidrohr avatar Nov 24 '24 17:11 davidrohr

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0 async-2024-PbPb-cpass0 async-2024-PbPb-apass1 async-2024-ppRef-apass1

github-actions[bot] avatar Dec 02 '24 14:12 github-actions[bot]

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Feb 16 '25 01:02 github-actions[bot]

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0 async-2024-PbPb-apass1 async-2024-ppRef-apass1 async-2024-PbPb-apass2 async-2023-PbPb-apass5

github-actions[bot] avatar Feb 22 '25 01:02 github-actions[bot]