AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

Improved treatment of recursive defines

Open pbuehler opened this issue 1 year ago • 3 comments

@vkucera This solves the issue with the failing documentation updates you mentioned recently.

pbuehler avatar Jul 09 '24 09:07 pbuehler

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass3 async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

Error while checking build/O2/fullCI for e62c04181eae48f8231d7a9667628a4fbfbbdeb1 at 2024-07-10 06:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

alibuild avatar Jul 10 '24 04:07 alibuild

Hi @pbuehler, why is this needed for production tags?

alcaliva avatar Aug 07 '24 10:08 alcaliva

Hello @pbuehler ,

I am removing the labels, since we think that this PR is not needed in production. Let us know if this is not the case, and we can add them back.

Chiara

chiarazampolli avatar Aug 09 '24 06:08 chiarazampolli