AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

[EMCAL-539,EMCAL-696,EMCAL-697] FIT-CTP-EMCAL trigger simulation

Open siragoni opened this issue 1 year ago • 4 comments

  • added the EMCAL trigger simulation in the Digitizer workflow
  • added the CTP input digits with the result of the trigger simulation
  • fixed MB trigger string in CTP simulation
  • added the CTP-EMC L0 accept

siragoni avatar Jun 18 '24 08:06 siragoni

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass3 async-2023-pbpb-apass4 async-2022-pp-apass6-2023-PbPb-apass2 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0

github-actions[bot] avatar Jun 18 '24 08:06 github-actions[bot]

Error while checking build/O2/fullCI for 030814e6db69860dc3578f66e3d9f1348a8358ca at 2024-06-18 10:40:

No log files found

Full log here.

alibuild avatar Jun 18 '24 08:06 alibuild

@mfasDa @jokonig Hi Markus, Joshua, I think I am ready now for you to have a look and point out edits you would like to be implemented

siragoni avatar Jun 18 '24 08:06 siragoni

Error while checking build/O2/fullCI for 50a4dd1b24b38610c9e302075d81e0d45768a587 at 2024-06-18 11:01:

No log files found

Full log here.

alibuild avatar Jun 18 '24 09:06 alibuild

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Sep 21 '24 01:09 github-actions[bot]

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0

github-actions[bot] avatar Oct 11 '24 15:10 github-actions[bot]

Error while checking build/O2/fullCI for 1c763e1ab5970e890fe3e605b6455845a3babe77 at 2024-10-11 19:24:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13227-slc8_x86-64/0/Detectors/EMCAL/simulation/src/DigitizerTRU.cxx:461:18: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild avatar Oct 11 '24 17:10 alibuild

Adding @sawenzel @shahor02 for the review.

ktf avatar Oct 16 '24 08:10 ktf

Yes, technically, I can merge it, but it would be good if @sawenzel approved it since this is a simulation code. I will add @jokonig as a code owner instead of @mfasDa .

shahor02 avatar Oct 16 '24 14:10 shahor02

Should squash the commits together to keep as an atomic development.

sawenzel avatar Oct 16 '24 14:10 sawenzel

I've checked, actually, @jokonig is the code owner of the EMCAL directories, but here the modifications are in the CTP ...

shahor02 avatar Oct 16 '24 14:10 shahor02

I've checked, actually, @jokonig is the code owner of the EMCAL directories, but here the modifications are in the CTP ...

Hi @shahor02 yes, this is why I was saying we have missing rights. There were a few modifications that we did over the course of months, a few of them Roman implemented himself afterwards, but still one thing that Markus wanted to add are here in this PR

siragoni avatar Oct 16 '24 15:10 siragoni