AliceO2
AliceO2 copied to clipboard
[MCH] change settings for MUON_SYNC_RECO
- keep default time offset correction in sync mode
- limit on max track candidates already set appropriately for pp and PbPb through MCH_CONFIG_KEY
- change tracking parameters to cope for possible misalignment only for pp or cosmics. Keep default values for PbPb to avoid large combinatorics. I see no particular reason not to use the defaults for synthetic.
@aferrero2707 , does it look ok for you?
REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-
+async-label <label1>, <label2>, !<label3> ...
This will add <label1>
and <label2>
and removes <label3>
.
The following labels are available async-2023-pbpb-apass3 async-2023-pbpb-apass4 async-2022-pp-apass6-2023-PbPb-apass2 async-2022-pp-apass4 async-2022-pp-apass4-accepted async-2022-pp-apass6-2023-PbPb-apass2-accepted async-2023-pbpb-apass3-accepted async-2023-pbpb-apass4-accepted async-2023-pp-apass4 async-2023-pp-apass4-accepted async-2024-pp-apass1 async-2024-pp-apass1-accepted async-2022-pp-apass7 async-2022-pp-apass7-accepted async-2024-pp-cpass0 async-2024-pp-cpass0-accepted
@pillot looks good to me, sorry for the delay!
Hi @shahor02 , this PR is validated from the MUON side (thanks Andrea). If this is OK for you too, can you force-merge it please (as for others, the test failures are due to git fetch issues)?
@shahor02 @pillot what is the status of this PR? Can it be merged? Thanks!
Error while checking build/O2/fullCI for a89b73892e7a044f7d0561e9dc0582c38e6794d4 at 2024-07-08 18:19:
++ rsync -a '--exclude=**/.git' --delete --delete-excluded /sw/SOURCES/O2DPG/13139-slc8_x86-64/0/ /sw/slc8_x86-64/O2DPG/13139-slc8_x86-64-local3/
++ mkdir -p etc/modulefiles
++ alibuild-generate-module --bin
BUILD_REQUIRES=alibuild-recipe-tools defaults-release
FULL_BUILD_REQUIRES=alibuild-recipe-tools defaults-release
DEFAULTS_RELEASE is a build_requires. Skipping loading the associated module.
++ cat
++ mkdir -p /sw/slc8_x86-64/O2DPG/13139-slc8_x86-64-local3/etc/modulefiles
++ rsync -a --delete etc/modulefiles/ /sw/slc8_x86-64/O2DPG/13139-slc8_x86-64-local3/etc/modulefiles
Full log here.
Hi, this PR is ready since more than a month now. Can someone please merge it? Thanks in advance.
Hi @shahor02 , @sawenzel , @pzhristov, can one of you merge this PR for the core team? This would be important to have the change before the PbPb 2024 run. Thanks a lot, Laure