AliceO2
AliceO2 copied to clipboard
Published
20 hours ago •
AliceO2Group
AliceO2Group
TRD: calibration: vDrift and ExB
This patch series does the following:
- reusing fit values from the previous slot
- pulling the initial fit values from the ccdb if there was any which is still valid e.g. ~in the last hour
- introduced a new flag
--min-entries-chamberfor more granular control on the minimum amount of entries a chamber should have for refitting - introduced a new constant for trd
- some minor touch-ups and doxygen compliant comments
more info in commits.
There were some concerns about the TrackletTransformer however looking through the code vDrift and ExB are only used for calculating the calibrated Dy (where it is a good thing to use updated values anyways) and for caluclation of the Timebin here, where an updated vDrift would also be good? How do I test this?
I tested it by comparing the fit values before and after for a Run 523677.
I did not have a chance to test if the actual pull for the initial fit values works as I expect, this is somewhat hard for me to test.
Error while checking build/O2/o2-dataflow-cs8 for 5422c903c02fca84f747e29ff7fa92a58b5b4224 at 2022-10-12 17:09:
## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/10053-slc8_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:69:31: error: no matching function for call to 'o2::trd::CalibratorVdExB::retrievePrev()'
ninja: build stopped: subcommand failed.
Full log here.
Error while checking build/O2/o2-dataflow for 4d67e60057c17aaeddde2b82315d821b4b5f6fce at 2022-10-12 17:16:
## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/10053-slc7_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:69:31: error: no matching function for call to 'o2::trd::CalibratorVdExB::retrievePrev()'
ninja: build stopped: subcommand failed.
Full log here.
Error while checking build/O2/fullCI for cc1b7d3dcdc21bd2127b3161a11db3f224d22504 at 2022-10-14 06:55:
[516/669] Building CXX object PWGMM/Mult/Tasks/CMakeFiles/O2Physicsexe-analysis-mm-assessment-mft.dir/assessment-mft.cxx.o
[517/669] Building CXX object PWGMM/Mult/TableProducer/CMakeFiles/O2Physicsexe-analysis-mm-particles-to-tracks.dir/particles2tracks.cxx.o
[518/669] Linking CXX executable stage/bin/o2-analysis-mm-assessment-mft
[519/669] Linking CXX executable stage/bin/o2-analysis-mm-particles-to-tracks
[520/669] Building CXX object PWGMM/Mult/Tasks/CMakeFiles/O2Physicsexe-analysis-mm-effpt-mft.dir/effpt-mft.cxx.o
[521/669] Building CXX object PWGMM/Mult/TableProducer/CMakeFiles/O2Physicsexe-analysis-mm-track-propagation.dir/trackPropagation.cxx.o
[522/669] Linking CXX executable stage/bin/o2-analysis-mm-effpt-mft
[523/669] Linking CXX executable stage/bin/o2-analysis-mm-track-propagation
[524/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-upc-forward.dir/upcForward.cxx.o
[525/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-upc.dir/upcAnalysis.cxx.o
[526/669] Linking CXX executable stage/bin/o2-analysis-ud-upc-forward
[527/669] Linking CXX executable stage/bin/o2-analysis-ud-upc
[528/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-dgcand-analyzer.dir/DGCandAnalyzer.cxx.o
[529/669] Building CXX object PWGMM/UE/Tasks/CMakeFiles/O2Physicsexe-analysis-mm-ue-charged.dir/uecharged.cxx.o
[530/669] Linking CXX executable stage/bin/o2-analysis-ud-dgcand-analyzer
[531/669] Linking CXX executable stage/bin/o2-analysis-mm-ue-charged
[532/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-diff-mcqa.dir/diffMCQA.cxx.o
[533/669] Linking CXX executable stage/bin/o2-analysis-ud-dgcand-producer
[534/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-upccand-analyzer.dir/UPCCandidateAnalyzer.cxx.o
[535/669] Linking CXX executable stage/bin/o2-analysis-ud-diff-mcqa
[536/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-diff-mcdatascanner.dir/diffMCDataScanner.cxx.o
[537/669] Linking CXX executable stage/bin/o2-analysis-ud-upccand-analyzer
[538/669] Linking CXX executable stage/bin/o2-analysis-simple-apply-pid-onnx-model
[539/669] Linking CXX executable stage/bin/o2-analysis-ud-diff-mcdatascanner
[540/669] Linking CXX executable stage/bin/o2-analysis-simple-apply-pid-onnx-interface
[541/669] Building CXX object PWGUD/Tasks/CMakeFiles/O2Physicsexe-analysis-ud-diff-qa.dir/diffQA.cxx.o
[542/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-histogram-track-selection.dir/src/histogramTrackSelection.cxx.o
[543/669] Linking CXX executable stage/bin/o2-analysis-ud-diff-qa
[544/669] Building CXX object PWGUD/TableProducer/CMakeFiles/O2Physicsexe-analysis-ud-upccand-producer.dir/UPCCandidateProducer.cxx.o
[545/669] Building CXX object PWGUD/TableProducer/CMakeFiles/O2Physicsexe-analysis-ud-dgbccand-producer.dir/DGBCCandProducer.cxx.o
[546/669] Linking CXX executable stage/bin/o2-analysis-ud-upccand-producer
[547/669] Linking CXX executable stage/bin/o2-analysis-ud-dgbccand-producer
[548/669] Building CXX object Tools/PIDML/CMakeFiles/O2Physicsexe-analysis-qa-pid.dir/qaPid.cxx.o
[549/669] Linking CXX executable stage/bin/o2-analysistutorial-histogram-track-selection
[550/669] Building CXX object Tools/PIDML/CMakeFiles/O2Physicsexe-analysis-qa-pid-ml.dir/qaPidML.cxx.o
[551/669] Linking CXX executable stage/bin/o2-analysis-qa-pid
[552/669] Linking CXX executable stage/bin/o2-analysis-qa-pid-ml
[553/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-track-iteration.dir/src/trackIteration.cxx.o
[554/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-collision-tracks-iteration.dir/src/collisionTracksIteration.cxx.o
[555/669] Linking CXX executable stage/bin/o2-analysistutorial-track-iteration
[556/669] Linking CXX executable stage/bin/o2-analysistutorial-collision-tracks-iteration
[557/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-new-collections.dir/src/newCollections.cxx.o
[558/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-full-track-iteration.dir/src/fullTrackIteration.cxx.o
[559/669] Linking CXX executable stage/bin/o2-analysistutorial-new-collections
[560/669] Linking CXX executable stage/bin/o2-analysistutorial-full-track-iteration
[561/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-dynamic-columns.dir/src/dynamicColumns.cxx.o
[562/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-associated-derived.dir/src/associatedExample.cxx.o
[563/669] Linking CXX executable stage/bin/o2-analysistutorial-dynamic-columns
[564/669] Linking CXX executable stage/bin/o2-analysistutorial-associated-derived
[565/669] Building CXX object Tutorials/CMakeFiles/O2Physicsexe-analysistutorial-histograms.dir/src/histograms.cxx.o
Full log here.
Also after I have merged my PR there is a conflict in the README which needs to be fixed
Error while checking build/O2/fullCI for 9480a1063c6382c2e0497f5fff7033fcaf9d81a8 at 2022-10-28 10:20:
## sw/BUILD/o2checkcode-latest/log
/sw/SOURCES/O2/10053-slc8_x86-64/0/GPU/Common/test/testGPUsortCUDA.cu:22:10: error: 'boost/test/unit_test.hpp' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/GPU/GPUTracking/TRDTracking/GPUTRDTracker.cxx:37:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/GPU/GPUTracking/Base/GPUReconstructionCPU.cxx:45:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/GPU/GPUTracking/Base/GPUReconstruction.cxx:37:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/GPU/GPUTracking/display/GPUDisplay.cxx:36:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/GPU/GPUTracking/Base/cuda/GPUReconstructionCUDAGenRTC.cu:16:10: error: 'omp.h' file not found [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/cuda/../Shared/Utils.h:26:10: error: 'boost/program_options.hpp' file not found [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/cuda/../Shared/Utils.h:26:10: error: 'boost/program_options.hpp' file not found [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/../Shared/Utils.h:146:34: error: use of undeclared identifier 'int4'; did you mean 'int'? [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:8: error: unknown type name '__host__' [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:27: error: expected ';' after top level declarator [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:33: error: overloaded 'operator+=' must have at least one parameter of class or enumeration type [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:44: error: unknown type name 'int4'; did you mean 'int'? [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:64:53: error: unknown type name 'int4'; did you mean 'int'? [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:66:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:66:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:67:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:67:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:68:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:68:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:69:4: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:69:11: error: member reference base type 'int' is not a structure or union [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:85:1: error: unknown type name '__global__' [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:19: error: use of undeclared identifier 'blockIdx' [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:32: error: use of undeclared identifier 'blockDim' [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:45: error: use of undeclared identifier 'threadIdx' [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/Kernels.hip.cxx:90:78: error: use of undeclared identifier 'blockDim' [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/../Shared/Utils.h:146:34: error: use of undeclared identifier 'int4'; did you mean 'int'? [clang-diagnostic-error]
/O2/GPU/GPUbenchmark/hip/benchmark.hip.cxx:199:35: error: use of undeclared identifier 'int4'; did you mean 'int'? [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/Framework/Logger/include/Framework/Logger.h:14:10: error: 'fairlogger/Logger.h' file not found [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:520:12: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1059:69: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1175:5: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1852:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:2276:18: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:4336:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/sm_20_atomic_functions.h:89:39: error: redefinition of 'atomicAdd' [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/Framework/Logger/include/Framework/Logger.h:14:10: error: 'fairlogger/Logger.h' file not found [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:520:12: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1059:69: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1175:5: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:1852:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:2276:18: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/cuda/std/detail/libcxx/include/type_traits:4336:16: error: CUDA device code does not support variadic functions [clang-diagnostic-error]
/usr/local/cuda-11.7/include/sm_20_atomic_functions.h:89:39: error: redefinition of 'atomicAdd' [clang-diagnostic-error]
/O2/Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h:36:10: error: 'omp.h' file not found [clang-diagnostic-error]
/O2/Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h:36:10: error: 'omp.h' file not found [clang-diagnostic-error]
/O2/Detectors/EMCAL/calibration/include/EMCALCalibration/EMCALCalibExtractor.h:36:10: error: 'omp.h' file not found [clang-diagnostic-error]
/sw/SOURCES/O2/10053-slc8_x86-64/0/Detectors/TOF/calibration/src/TOFChannelCalibrator.cxx:23:10: error: 'omp.h' file not found [clang-diagnostic-error]
Full log here.
Error while checking build/O2/o2 for 9480a1063c6382c2e0497f5fff7033fcaf9d81a8 at 2022-10-19 13:04:
## sw/BUILD/O2-latest/log
464/464 Test #420: o2sim_hepmc ..........................................................................***Timeout 400.01 sec
99% tests passed, 1 tests failed out of 464
100% tests passed, 0 tests failed out of 102
Full log here.
Error while checking build/O2/o2-dataflow-cs8 for 9480a1063c6382c2e0497f5fff7033fcaf9d81a8 at 2022-10-21 13:49:
## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 441
100% tests passed, 0 tests failed out of 102
## sw/BUILD/QualityControl-latest/log
1/39 Test #2: testMonitorObject .......................***Timeout 30.02 sec
97% tests passed, 1 tests failed out of 39
Full log here.
Error while checking build/O2/fullCI for 8403ac738001caf0466b9a8a0deac4ef0c734d61 at 2022-11-16 07:25:
## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.
Full log here.