Ali-RS comments

Results 157 comments of


                                            Ali-RS

AnimComposer: Add Features/Potential issues

> What was wrong with PR #1038 ? I think it had not been reviewed. I am not sure why I closed it though!

AnimComposer: Add Features/Potential issues

@TehLeo regarding > there is a jump at the point when the animation should repeat. Maybe `BlendableAction.setTransitionLength(0)` can help with this. See https://hub.jmonkeyengine.org/t/solved-animation-does-not-loop-properly/43272/8?u=ali_rs

AnimComposer: Add Features/Potential issues

In my case, I use [TweenAnimation](https://github.com/jMonkeyEngine-Contributions/Lemur/blob/master/src/main/java/com/simsilica/lemur/anim/TweenAnimation.java#L48) for my tweens and play them with [EffectControl](https://github.com/jMonkeyEngine-Contributions/Lemur/blob/master/src/main/java/com/simsilica/lemur/effect/EffectControl.java) In TweenAnimation I can also control the looping, I can also extend it to support loop...

AnimComposer: Add Features/Potential issues

>How would you construct this reverse tween? Something like this: public class Invert implements Tween { private Tween delegate; public Invert( Tween delegate ) { this.delegate = delegate; } public...

Java source files with missing or non-standard copyright notices

> com.jme3.anim.AnimClip > com.jme3.anim.AnimComposer > com.jme3.anim.AnimTrack > com.jme3.anim.AnimationMask > com.jme3.anim.Armature > com.jme3.anim.ArmatureMask > com.jme3.anim.Joint > com.jme3.anim.MatrixJointModelTransform > com.jme3.anim.MorphControl > com.jme3.anim.SeparateJointModelTransform > com.jme3.anim.Weights > com.jme3.anim.interpolator.* > com.jme3.anim.tween.* > com.jme3.anim.tween.action.* > com.jme3.anim.util.*...

Java source files with missing or non-standard copyright notices

@pspeed42 now that jme core utilise Tweens, do you think it would be good idea to deprecate them from Lemur and put them in jme core ? Lemur already has...

Java source files with missing or non-standard copyright notices

> I think they were changed after moving, weren't they? Yes, the following has changed: A new interface added https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/anim/tween/ContainsTweens.java and Parallel, Sequence, Stretch tweens implement it. And `AbstractTween` now...