Ali-RS
Ali-RS
>We should make writeImageFile independant of the type, you just pass it, so that screenshots could run their conversion before calling writeImageFile Hmm, but shouldn't it know the type to...
Please see this fix: https://github.com/jMonkeyEngine/jmonkeyengine/pull/1851
Another idea might be to consider deprecating ReflectionAllocator.
Sorry @stephengold, I thought I have already deleted that comment. I guess it's too late to delete it now but I will adjust it to sense a bit nice;) You...
@stephengold can you try with AdoptOpenJDK? AFAIK LWJGL2 is not compatible with OpenJDK 12+ (also with some versions of OpenJDK 11, IIRC 11.0.6+) Otherwise, I think you should use LWJGL3...
@stephengold were you able to reproduce the "Buffer cannot be destroyed" crash?
A note for anyone who wants to try this with LWJGL3: LWJGL3 will **statically** register its own buffer allocator at LwjglContext: https://github.com/jMonkeyEngine/jmonkeyengine/blob/ceb356462aeedf7769dced52e1d5572b01deca31/jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglContext.java#L93-L104 which will be **statically** initialized at this line...
>Does anyone know if it is used outside of the lwjgl2 renderer? Yes, `AndroidBufferAllocator` uses it. It is error-prone on android as well. See https://hub.jmonkeyengine.org/t/androidbufferallocator-and-nonsdkapiusedviolation/45124/2?u=ali_rs For Android, a workaround may...
Is `NativeAllocator` an interface? or a class that implements the `BufferAllocator` interface and should exist in all render modules (lwjgl3, lwjgl, android)?
Ok, that sounds good to me.