bloomer icon indicating copy to clipboard operation
bloomer copied to clipboard

Add File Upload to Forms

Open aszecsei opened this issue 6 years ago • 6 comments

This resolves #97 and adds a collection of the File Upload elements that Bulma uses, documented here.

I had unrelated issues getting the documentation to build (#105), so there may be some problems with my additions for that.

aszecsei avatar Jul 06 '18 00:07 aszecsei

Coverage Status

Coverage remained the same at 100.0% when pulling cad72bb3812029749d29a86b44ec678b246bf828 on aszecsei:add-file-upload into 0ab9c677c3ffe541d775f9ad60a6b1f86a6634fc on AlgusDark:master.

coveralls avatar Jul 06 '18 00:07 coveralls

Having this would be awesome 🚀

lveillard avatar Sep 09 '18 11:09 lveillard

@AlgusDark unfortunately changing that didn't affect the docs building - there are a ton of errors I'm getting from files I didn't touch, like

    TS1013: A rest parameter or binding pattern may not have a trailing comma.

Those are easy enough to solve, but then there are ones like

    TS2322: Type '{ className: string; accept?: string; acceptCharset?: string; action?: string;
allowFullScreen?: ...' is not assignable to type 'DetailedHTMLProps<TextareaHTMLAttributes<HTMLTextAreaElement>, HTMLTextAreaElement>'.
  Type '{ className: string; accept?: string; acceptCharset?: string; action?: string; allowFullScreen?: ...' is not assignable to type 'ClassAttributes<HTMLTextAreaElement>'.
    Types of property 'ref' are incompatible.
      Type 'Ref<HTMLElement>' is not assignable to type 'Ref<HTMLTextAreaElement>'.
        Type 'RefObject<HTMLElement>' is not assignable to type 'Ref<HTMLTextAreaElement>'.
          Type 'RefObject<HTMLElement>' is not assignable to type 'RefObject<HTMLTextAreaElement>'.
            Type 'HTMLElement' is not assignable to type 'HTMLTextAreaElement'.
              Property 'autofocus' is missing in type 'HTMLElement'.

Honestly not even sure where to start trying to fix those 🙁

aszecsei avatar Sep 16 '18 02:09 aszecsei

@aszecsei I don't have Internet right now (until end of the month I will have). I'll check and make changes on Master branch 🤔

This project needs to get some updates from TS. After that, we shouldn't have any problems.

First of all, thanks for this. Please let's wait for my chages 🙏 so sorry.

AlgusDark avatar Sep 16 '18 02:09 AlgusDark

@AlgusDark Are you planning to merge this? :)

enessoylu avatar Mar 08 '19 08:03 enessoylu

Hi Guys,

Anyone working on this?

I don't see the file upload input in the list of available form elements.

Thanks.

arthurkhlghatyan avatar Jul 12 '19 10:07 arthurkhlghatyan