AlgebraicDynamics.jl icon indicating copy to clipboard operation
AlgebraicDynamics.jl copied to clipboard

Performance warning from SciML

Open jpfairbanks opened this issue 2 years ago • 0 comments

628
     Testing Running tests...
[629](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:632)
Test Summary: | Pass  Total   Time
[630](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:633)
UWDDynam      |   55     55  38.5s
[631](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:634)
Test Summary: | Pass  Total   Time
[632](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:635)
DWDDynam      |   54     54  53.1s
[633](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:636)
Test Summary: | Pass  Total   Time
[634](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:637)
CPGDynam      |   71     71  22.2s
[635](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:638)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[636](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:639)
│ Consider using tuples instead.
[637](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:640)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[638](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:641)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[639](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:642)
│ Consider using tuples instead.
[640](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:643)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[641](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:644)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[642](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:645)
│ Consider using tuples instead.
[643](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:646)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32
[644](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:647)
┌ Warning: Using arrays or dicts to store parameters of different types can hurt performance.
[645](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:648)
│ Consider using tuples instead.
[646](https://github.com/AlgebraicJulia/AlgebraicDynamics.jl/actions/runs/5347756391/jobs/9696703768?pr=123#step:7:649)
└ @ SciMLBase ~/.julia/packages/SciMLBase/s9wrq/src/performance_warnings.jl:32

In the current PR #123 we get some warnings that should be run down. It looks like we are passing parameters as an array instead of a tuple somewhere. This is a good first issue and a potentially breaking change.

jpfairbanks avatar Jun 22 '23 16:06 jpfairbanks