Make the rb name compliant with ADF by default

[mauriziovitale]

[CLAassistant]

All committers have signed the CLA.

[salaboy]

@igdianov I wouldn't merge this until we fix the internal charts and then we start renaming. I wouldn't also change this at the helm chart level, I would like to change it at the spring boot app level. The current convention used for names in the product doesn't make too much sense for community modules due several restrictions. We can make their life simpler by renaming the right things in the right places, but I don't want those restrictions to creep in the community space.

[mauriziovitale]

@mauriziovitale What about query and audit service names used by ADF, i.e. rb-query and rb-audit?

The query is not a problem because the service is already called name: query some for audit name: audit @salaboy If we don't do that we need to have documentation that says to replace the rb service name from name: rb-my-app to name: rb otherwise ADF won't work!

[magemello]

just a remainder we already agreed on names which are:

/audit /query /rb /notifications /modeling-service /modeling /identity.{domain}/auth /gateway.{domain}/

[igdianov]

@mauriziovitale @salaboy We will merge this when it is time.

[salaboy]

@igdianov please do not merge.. I see some issues here.. if we want to change the service names, we should change them in the service itself. I would like to remove from the default values file the "service" -> "name" is it should be defaulted from the Kubernetes Service Descriptor which should use the spring.application.name

[igdianov]

@salaboy Makes sense to me. We should fix the source rather than patch the chart.