hammond icon indicating copy to clipboard operation
hammond copied to clipboard

Incorrect values calculated when submitting fill-up using different measurements than vehicle type (EG Liters VS Gallons)

Open alexanderfitu opened this issue 2 years ago • 1 comments

Describe the bug

When vehicle type set to "Gallons", you are unable to enter a fill-up log with the fuel quantity value set to "Liters", If you do, the generated fuel economy graph gives implausible values.

To Reproduce

  • Go to 'create fillup'
  • Enter all details, and change the unit type from vehicle default to something else
  • Press submit

Expected behavior

The calculated fill value should be units X quantity and this should then be entered.

Additional context

This may be an outlying use case, but in the UK we measure our fuel economy in Miles per (imperial) gallon, but measure and pay for fuel in Liters and £ per litre (which is silly I know).

This means that the fuel economy screen on the vehicle summary shows Miles per Litre which is an unusual unit here.

I think a workaround is to change fuel unit under vehicle to "Gallons" to show MPG chart, then back to "Liters" for day to day filling, but I do not know if this has other implications.

Changing the fuel type after adding fill-ups only changes the graph labelling, so not a suitable workaround.

alexanderfitu avatar Jan 29 '23 11:01 alexanderfitu