AlexxIT
Add healthcheck
This is work in progress, I will write more details before I mark it as ready for review.
Benefits:
- Hass Supervisor watchdog (if enabled) will restart the container once it is unhealthy
For now, this is blocked by:
- https://github.com/moby/buildkit/issues/4355
@felipecrs as go2rtc has static config path in docker, you could parse config file and use it in healthcheck sh script. It's possibility describes here https://stackoverflow.com/questions/55375371/using-a-sh-script-for-docker-healthchecks Anyway I've never seen go2rtc hanging... As variant, you could parse output existence of "go2rtc --version"
Anyway I've never seen go2rtc hanging...
People in Frigate's world have seen go2rtc hanging many times. That's why Frigate (myself) built its own healthcheck for go2rtc to restart it when it hangs.
I, for one, have an issue open that describes a hanging situation happening in latest version 1.8.4:
- https://github.com/AlexxIT/go2rtc/issues/762 (read last two paragraphs)
As variant, you could parse output existence of "go2rtc --version"
I don't see how invoking a new go2rtc process would help to assess the functionality of the existing one.
@felipecrs as go2rtc has static config path in docker, you could parse config file and use it in healthcheck sh script. It's possibility describes here https://stackoverflow.com/questions/55375371/using-a-sh-script-for-docker-healthchecks
That's a very good idea, and it was what I was intending to do too. But then I forgot about this PR. lol
I mean I had never seen hanging go2rtc myself and I don't know what exactly needs to check like rtsp port or web port. What is staying accessed when process hangs.
Probably it could be related to this pr https://github.com/AlexxIT/go2rtc/pull/440 to track for example sighup signal
@felipecrs unfortunately I don't know how to reproduce go2rtc hanging in my environment. I think more complex solution is needed here than just to check open ports, because we don't know how the process behaves itself in hanging state. I saw your homeassistant automation to check stream status and in my opinion this is the best solution at the moment.
Very dirty solution for frigate is parsing /dev/shm/logs/go2rtc/current for phrase "sync.(*Mutex).Lock(...)", "goroutine" of "WRN [streams] json locked" like tail -f /dev/shm/logs/go2rtc/current | grep "json locked"