XiaomiGateway3 icon indicating copy to clipboard operation
XiaomiGateway3 copied to clipboard

Fix overriding deprecated method of NumberEntity

Open HepoH3 opened this issue 3 years ago • 4 comments

Currently there is a warning:

custom_components.xiaomi_gateway3.number::XiaomiNumber is overriding deprecated methods on an instance of NumberEntity, this is not valid and will be unsupported from Home Assistant 2022.10

This change fix warning, but I'm a bit of confused because the old method is not explicitly used anywhere, so I changed the override only.

For now everything works smooth on my setup.

Fix: #777, #780.

HepoH3 avatar Aug 02 '22 08:08 HepoH3

This change will break backward compatibility of many Hass versions. I can't accept it

AlexxIT avatar Aug 02 '22 08:08 AlexxIT

You mean integration will stop working on some installation with HA core older some version?

HepoH3 avatar Aug 02 '22 08:08 HepoH3

Yes. All 2022 won't work

AlexxIT avatar Aug 02 '22 12:08 AlexxIT

I got you, no problem — it can wait if you don't mind.

HepoH3 avatar Aug 02 '22 12:08 HepoH3

Thanks! I'll add backward compatibility

AlexxIT avatar Aug 12 '22 14:08 AlexxIT