MSYS2-pacman icon indicating copy to clipboard operation
MSYS2-pacman copied to clipboard

Published 20 hours ago • verified publisher icon Alexpux

Refactor tidy patches into plugins

Open elieux opened this issue 9 years ago • 5 comments

I see there are some big patches for the tidying phase of makepkg. Now that the phase is extendable, maybe some of the MSYS2-specific code should be put into separate files for better maintainability?

elieux avatar Feb 03 '15 14:02 elieux

it already put. See develop branch. I'm build pacman with this changes when I test it.

Alexpux avatar Feb 03 '15 14:02 Alexpux

Yeah, I know that you already merged the change into msys2-pacman. I meant that the strip plugin is now very big and does various stuff not related to stripping, for example handling executable files without .exe extension (https://github.com/Alexpux/MSYS2-pacman/blob/develop/scripts/libmakepkg/tidy/strip.sh.in#L86-101). Maybe this part of the strip plugin could now be a separate plugin.

elieux avatar Feb 03 '15 15:02 elieux

i don't want to split this code because it hard to maintain it. this procedures a get from cygwin build system.

Alexpux avatar Feb 03 '15 15:02 Alexpux

this procedures a get from cygwin build system

Could you point me to where you got these procedures? I found only cygbuild, but their code is very different to the one in MSYS2 makepkg.

elieux avatar Feb 03 '15 16:02 elieux

https://sourceforge.net/p/cygwin-ports/cygport/ci/master/tree/lib/src_postinst.cygpart

Search for "__prepstrip"

Alexpux avatar Feb 03 '15 17:02 Alexpux