node-v8-clone icon indicating copy to clipboard operation
node-v8-clone copied to clipboard

bump nan

Open heavyk opened this issue 9 years ago • 2 comments

won't compile on io.js without bumping nan.

needed to install gulp-helpers

cheers

heavyk avatar May 03 '15 17:05 heavyk

I see this fails on node 0.8. I suppose that would be expected though, as I don't think the latest nan supports 0.8

heavyk avatar May 03 '15 17:05 heavyk

Have you seen #8 and this branch: https://github.com/AlexeyKupershtokh/node-v8-clone/compare/io.js With these PRs the node-v8-clone indeed compiles with io.js but then the tests are failing. I'm afraid that fixing node-v8-clone for io.js would require major changes to prevent more types from reaching c++ Object.clone function. Currently I don't have much time to investigate further but any of your experiments are welcome.

AlexeyKupershtokh avatar May 04 '15 03:05 AlexeyKupershtokh