node-v8-clone icon indicating copy to clipboard operation
node-v8-clone copied to clipboard

Published 20 hours ago • verified publisher icon AlexeyKupershtokh

Fix io.js incompatibility

Open AlexeyKupershtokh opened this issue 9 years ago • 7 comments

AlexeyKupershtokh avatar Mar 19 '15 09:03 AlexeyKupershtokh

Referencing in iojs: https://github.com/iojs/io.js/issues/456

jtblin avatar Apr 08 '15 12:04 jtblin

Current status of the io.js branch: https://travis-ci.org/AlexeyKupershtokh/node-v8-clone/jobs/55111301

AlexeyKupershtokh avatar Apr 08 '15 12:04 AlexeyKupershtokh

oh did not see that. I just ran the test and saw that does not work... ok, so if I find myself with some spare time, I'll have a look. (maybe in certain cases I'll just disable the v8-clone - though it's weird that v8's casting causes a fatal error. could it potentially be a bug in v8 then?) anyway.. thanks!

EDIT: I commented on the wrong one. sorry about that. comment above was for #9

heavyk avatar May 05 '15 23:05 heavyk

The original error that is thrown from the io.js' v8 is the following:

# Fatal error in ../deps/v8/src/heap/heap.cc, line 3864
# CHECK(map->instance_type() == JS_OBJECT_TYPE || map->instance_type() == JS_ARRAY_TYPE) failed

So they explicitly forbid to clone anything like Number objects. This is what I've investigated so far.

AlexeyKupershtokh avatar May 06 '15 02:05 AlexeyKupershtokh

ah ok... I see what you're saying. yeah that could be a lot of work then... first I'd need to benckmark to see if c++ is actually faster than js, then make a bunch of exceptions... you're right, a total pain in the ass for an extension not often used... I'll put it low on the todo list ... lol

cheers mate

heavyk avatar May 06 '15 17:05 heavyk

Since iojs is going to be the "new" node going forward, do you plan on fixing this @AlexeyKupershtokh? I would love to use this module.

zeusdeux avatar May 16 '15 03:05 zeusdeux

Any update on this? Or, what is a good fast alternative to node-v8-clone today that we can switch at the meantime?

DmitrySoshnikov avatar Aug 11 '15 20:08 DmitrySoshnikov