Waybar icon indicating copy to clipboard operation
Waybar copied to clipboard

Fix Clock. Tooltip calendar text overflows(#2240)

Open LukashonakV opened this issue 1 year ago • 10 comments
trafficstars

Hi @Alexays, @FilippoBonazziSUSE this MR solves #2240 Actually here it's GtkLabel wrong behavior with tooltips. Even @BrianCArnold has found workaround it's better to have code fixed. Temporary for now I replaced clock label with Gtk::TextView. In order to have the same styling as it was for tooltips in the system, users should use next css styling

textview#clock.tooltip, textview#clock.tooltip text {
   background-color: inherit;
   padding: inherit;
}

For now I'm trying to write test case in pure C in order to provide it gtk maintainers to fix gtk

So fixed variant looks good ps_2024-05-11-01_06_12

LukashonakV avatar May 10 '24 22:05 LukashonakV

Hi @Alexays , ping )

LukashonakV avatar May 15 '24 11:05 LukashonakV

Hi @Alexays , finally this MR is ready to merge. According discussion here Label set_markup tooltips width for the Widget class is limited. So for now I found the better solution using one more Gtk::Label as a tooltip for the base Clock label. And then to set_markup for this tooltip label. Such approach allows solve #2240 without any additional CSS style customization from the user

LukashonakV avatar May 17 '24 17:05 LukashonakV

Hi @Alexays , ping

LukashonakV avatar May 18 '24 09:05 LukashonakV

Hi @Alexays , ping once again )

LukashonakV avatar May 20 '24 11:05 LukashonakV

Hi @Alexays , any feedback ?

LukashonakV avatar May 22 '24 08:05 LukashonakV

Hi @Alexays , ping again

LukashonakV avatar May 23 '24 13:05 LukashonakV

Amazing, thanks for this PR!

alkar avatar May 23 '24 14:05 alkar

@Alexays any feedback?

LukashonakV avatar May 23 '24 21:05 LukashonakV

@Alexays ?

LukashonakV avatar May 24 '24 04:05 LukashonakV

It looks like Alexays is unavailable right now (travelling, on vacation, ...). I'm sure he will see your pings once he is available again. I don't think pinging him every few hours helps.

FilippoBonazziSUSE avatar May 24 '24 07:05 FilippoBonazziSUSE

LGTM, and yes i was on vacation :)

Alexays avatar May 28 '24 07:05 Alexays

Thanks @LukashonakV for providing the fix, can't wait to try it out.

FilippoBonazziSUSE avatar May 28 '24 07:05 FilippoBonazziSUSE