Waybar icon indicating copy to clipboard operation
Waybar copied to clipboard

Add check for tooltip-format for custom modules

Open jones-josh opened this issue 1 year ago • 3 comments
trafficstars

Issue https://github.com/Alexays/Waybar/issues/2914 tries to use tooltip-format on a custom module without a script. This change results in tooltip-format entries in config being used as the tooltip format, over any tooltip-related return from the output of a custom script if there is one.

This makes the most sense to me as it is the more visible change. If I see a tooltip-format entry in the config file, I expect that this is truth, not the output of a script in a different place. While it wouldn't be best practice to setting the tooltip in both places, I'd argue that a user would expect that their change to the config would be reflected in the case of using a 3rd party script they don't fully understand.

jones-josh avatar Feb 16 '24 00:02 jones-josh

Of course will add to man and wiki as appropriate if approved of.

jones-josh avatar Feb 16 '24 00:02 jones-josh

LGTM

Alexays avatar Feb 16 '24 12:02 Alexays

Will add to wiki once merged

jones-josh avatar Feb 16 '24 14:02 jones-josh