Alexander Viand

Results 110 comments of Alexander Viand

> Can't use it as a binary because we're depending directly on the C++ API. I'll try FetchContent. Yep, they even have a nice example of how to do it...

> Should we add a separate pass for it (`polynomial-to-mod-arith`, lots of duplicate code) and gradually replace `polynomial-to-standard` or just placing it inside the `polynomial-to-standard` pass? What we’ve done in...

Awesome, thanks! Lots of good questions in your last post, so let me pick the easy one to answer xD > * The canonicalization rule SubAsAdd mentioned in [Fix upstream...

> Seems that I need to put `elementwise-to-affine` before `polynomial-to-mod-arith` as mentioned in #769 Yeah, I think that's a good idea. Not many things use the tensor-valued versions of polynomial,...

> Talking about moving some logic inside `mod_arith`. I think the handling of `modArithReduceOp` needs some change to `mod_arith.reduce`. > > [Note this will interpret x as a signed integer....

Thanks! Btw, I still see two files in `tests/old`- did you push all of your most recent changes? @ polynomial runner: I think my idea was that `Examples/` should really...

> Right! There is also some in `tools/*.bzl` now too, but I don't really see a difference in marking these macros as test vs non-test. I think we probably want...

@asraa Can you take a look at why the verilog tests fail? I don't see any obvious changes from how things were set up before.

Thanks! I just squashed & rebased, LGTM now :)

> I like this organization, I can't wait for it to be merged! > > Crossing my fingers that when it's merged it's a seamless transition for any open PRs...