Alexander Sehr

Results 120 comments of Alexander Sehr

It's a proper Resource Type - hence I see no need to 'not' have a module for it. We could also do this directly using the new dependency approach that...

> Pending change to the implementation approach: ![MicrosoftTeams-image](https://user-images.githubusercontent.com/28486158/195482885-6cfdf5b3-a70e-4efd-890f-569c3dfe0129.png) As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able...

> Pending change to the implementation approach: ![MicrosoftTeams-image](https://user-images.githubusercontent.com/28486158/195482885-6cfdf5b3-a70e-4efd-890f-569c3dfe0129.png) As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able...

> Pending change to the implementation approach: ![MicrosoftTeams-image](https://user-images.githubusercontent.com/28486158/195482885-6cfdf5b3-a70e-4efd-890f-569c3dfe0129.png) As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able...

> Pending change to the implementation approach: ![MicrosoftTeams-image](https://user-images.githubusercontent.com/28486158/195482885-6cfdf5b3-a70e-4efd-890f-569c3dfe0129.png) As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able...

The new dependency (aka 'pure bicep') approach could help. For the typeProperties object we could for example simply expect an object (i.e. leave it to the user to configure the...

> Pending change to the implementation approach: ![MicrosoftTeams-image](https://user-images.githubusercontent.com/28486158/195482885-6cfdf5b3-a70e-4efd-890f-569c3dfe0129.png) As per our discussion I'd suggest to push this back as neither the global.module.tests, nor especially the Set-ModuleReadMe function will be able...

I've seen a similar effect when working on the CMK implementation for other modules. It was usually not well documented and more try and error than anything else. I'll try...

[This](https://github.com/Azure/ResourceModules/blob/users/alsehr/1791_CognitiveServices_Accounts/modules/Microsoft.CognitiveServices/accounts/.test/encr/dependencies.bicep#:~:text=resource%20keyPermissions%20%27Microsoft.Authorization/roleAssignments%402022%2D04%2D01%27%20%3D%20%7B) is an approach we use for e.g. Cognitive Services CMK: ```Bicep resource keyPermissions 'Microsoft.Authorization/roleAssignments@2022-04-01' = { name: guid('msi-${keyVault::key.id}-${location}-${managedIdentity.id}-Key-Reader-RoleAssignment') scope: keyVault::key properties: { principalId: managedIdentity.properties.principalId roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '12338af0-0e69-4776-bea7-57ae8d297424') // Key...

Hey @MattLeach25 are you still planning to work in this issue? Otherwise we can re-assign it? :)