treemacs icon indicating copy to clipboard operation
treemacs copied to clipboard

Looks like some `all-the-icons` are not defined

Open vise890 opened this issue 1 year ago • 1 comments

It looks that when support for directory-specific icons was added in https://github.com/Alexander-Miller/treemacs/commit/f68a846f3ed593fa9ed081c45f0af9b1c67753a1, the all-the-icons theme slightly broke: image

I think this is because the custom dir icons were not added to https://github.com/Alexander-Miller/treemacs/blob/f68a846f3e/src/extra/treemacs-all-the-icons.el#L115.

As I workaround, I've generated a treemacs-modify-theme call that restores the original icons for the custom directories in all-the-icons:

Click to expand
(treemacs-modify-theme
 "all-the-icons"
 :config
 (progn
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("src-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("src-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("test-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("test-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("bin-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("bin-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("build-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("build-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("git-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("git-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("github-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("github-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("public-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("public-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("private-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("private-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("temp-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("tmp-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("temp-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("tmp-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("readme-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("docs-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("readme-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("docs-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("screenshots-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-right"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("icons-closed")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("screenshots-open")
   :fallback
   'same-as-icon)
  (treemacs-create-icon
   :icon
   (format
    "%s%s%s%s"
    (all-the-icons-octicon
     "chevron-down"
     :height
     0.75
     :v-adjust
     0.1
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab
    (all-the-icons-octicon
     "file-directory"
     :v-adjust
     0
     :face
     'treemacs-all-the-icons-file-face)
    treemacs-all-the-icons-tab)
   :extensions
   ("icons-open")
   :fallback
   'same-as-icon)))

Would you be interested in a PR adding that? Would we want to try and find better all-the-icons for test/screenshots/etc?

Thank you in advance & thanks for the package, I love it :)

vise890 avatar Apr 12 '23 14:04 vise890

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jun 11 '23 20:06 stale[bot]