NCDatasets.jl
NCDatasets.jl copied to clipboard
Prepare common data model 0.4
This PR requires: https://github.com/JuliaGeo/CommonDataModel.jl/pull/35
The PR is related to the following issues https://github.com/JuliaGeo/CommonDataModel.jl/issues/32 and https://github.com/JuliaGeo/NCDatasets.jl/issues/274
Content
- Bump CommonDataModel to 0.4 (Not merged yet).
- Remove
DiskArrays.@implement_diskarray.Variableis now a subtype ofAbstractDiskArrayso this is not needed anymore. - Remove the custom code for
subsubused for views. This is not needed anymore since the DiskArrays views are now used.
The PR have been tested offline by
- Clone https://github.com/JuliaGeo/CommonDataModel.jl/pull/35
- Use Pkg
devto add the local repo as dependency - Run tests.
All tests pass on my MacOS, Julia 1.11
Thanks a lot Simon for your great work! I am merging your PR.
Can we register this change? Is this breaking or not?