NCDatasets.jl icon indicating copy to clipboard operation
NCDatasets.jl copied to clipboard

Prepare common data model 0.4

Open lupemba opened this issue 6 months ago • 1 comments

This PR requires: https://github.com/JuliaGeo/CommonDataModel.jl/pull/35

The PR is related to the following issues https://github.com/JuliaGeo/CommonDataModel.jl/issues/32 and https://github.com/JuliaGeo/NCDatasets.jl/issues/274

Content

  • Bump CommonDataModel to 0.4 (Not merged yet).
  • Remove DiskArrays.@implement_diskarray. Variable is now a subtype of AbstractDiskArray so this is not needed anymore.
  • Remove the custom code for subsub used for views. This is not needed anymore since the DiskArrays views are now used.

lupemba avatar Jun 22 '25 08:06 lupemba

The PR have been tested offline by

  • Clone https://github.com/JuliaGeo/CommonDataModel.jl/pull/35
  • Use Pkg dev to add the local repo as dependency
  • Run tests.

All tests pass on my MacOS, Julia 1.11

lupemba avatar Jun 22 '25 08:06 lupemba

Thanks a lot Simon for your great work! I am merging your PR.

Alexander-Barth avatar Sep 16 '25 13:09 Alexander-Barth

Can we register this change? Is this breaking or not?

felixcremer avatar Sep 30 '25 11:09 felixcremer