Alex Waygood comments

Results 893 comments of


                                            Alex Waygood

Don't emit Liskov violations w.r.t. grandparent class if the violation cannot be fixed without breaking Liskov w.r.t. the parent class

Hey @t-moe, thanks for the bug report! The issue here is with the parameter names. If I have a class hierarchy like this, then instances of `Bar` cannot be used...

Don't emit Liskov violations w.r.t. grandparent class if the violation cannot be fixed without breaking Liskov w.r.t. the parent class

> [@AlexWaygood](https://github.com/AlexWaygood) is this issue left open in order to track item (3)? Should we re-title it to reflect that? Do we have an issue for (2)? Yes. I have...

support calls to intersection types

IIRC, according to https://jellezijlstra.github.io/negation-types.html we should just ignore negative elements altogether for most operations on intersection types?

support calls to intersection types

sorry, should have read more carefully :( blame it on the fever.

Add more documentation to special forms in `ty_extensions.pyi` stub

Yes I think three things are required for good on-hover with `Unknown`: - Change the `Unknown` definition to `Unknown: _SpecialForm`. `Unknown = object()` is just really confusing because users get...

Default parameter values should be expressions, not types

Thanks! I agree that this is confusing and we should change this. We didn't have an issue before now for it though, so this is useful. There's some design work...

Default parameter values should be expressions, not types

@MichaReiser I don't just see this as a server issue FWIW — we have the same confusing display in our diagnostics emitted from the `ty_python_semantic` crate

Default parameter values should be expressions, not types

For anything complex (and I'd include "generated methods that don't have source code" in that bucket), I think we can just render the parameter default as `...`. That's still less...

Default parameter values should be expressions, not types

reopening. https://github.com/astral-sh/ruff/pull/22010 gets us to a much better state but I think there's still lots of improvements we can and should make to get to parity with Pylance here (and...

Emit diagnostic on unsound call to abstract `@classmethod` or `@staticmethod` with trivial body, when accessed on the class object itself

Note that instance methods don't need to be caught by this check, because if we implement https://github.com/astral-sh/ty/issues/1877 then it's basically impossible to call an abstract instance method. This check should...