Alex Waygood

Results 902 comments of Alex Waygood

Rebasing or merging in `main` often gets CodSpeed to change its mind as well

Hi, I'm sorry we broke your code! We certainly didn't do so intentionally. I think a few of the recent changes you mention were as a result of various performance...

> Yeah, I haven't been able to actually find the documentation Yes, I believe the only documentation we have is the README, and admittedly there are some things that probably...

Have you considered contributing your custom checker to sphinx-lint itself? We might be interested in a PR like that :)

I agree with @barneygale, @CAM-Gerlach, and @brettcannon (Brett voiced his opinions on the PR here: https://github.com/python/cpython/pull/31212#issuecomment-1132298550). There seems to be little point adding this method, if it's just a thin...

> Hm. I wouldn't want to encourage users to use `bytes` if they don't need to, or to put the thought in their minds. If we were to add it,...

> Relevant SO: https://stackoverflow.com/questions/45724240/processing-non-utf-8-posix-filenames-using-python-pathlib (I mainly use Windows so apologies if this question exposes my ignorance about bytes paths!) Are there any drawbacks to the solution given in the answer...

...Is the deprecation cycle for the `name` attribute really worth the hassle, and pain to users? I agree that that's how I might do it if I were writing `tempfile`...

> I'm still not convinced about this feature request, though. Is this not already easy and explicit? > > ```python > # currently possible > with NamedTemporaryFile() as tf: >...

Sorry, this dropped off my radar; will try to take a look soon!