Alex Waygood
Alex Waygood
> âšī¸ ecosystem check **detected linter changes**. (+6 -0 violations, +0 -0 fixes in 1 projects; 43 projects unchanged) These all look like true positives to me. The affected project...
> I'd also look at why Pylint doesn't trigger on them. Is there an issue in Pylint which might give us an insight here? Yeah, I'll do some digging and...
The results of digging: - The pylint check was originally added in https://github.com/pylint-dev/pylint/commit/a636569b9cc53279b3b5f4d24b58d9bc739b05d3, a commit that was pushed straight to pylint's `main` branch without a pull request. - The commit...
> I think these changes are correct but it would be useful to get a second opinion. @carljm, could you possibly take a look?
I opened a pylint issue here to let them know about the bug on their side: https://github.com/pylint-dev/pylint/issues/9584
The pylint maintainers have added labels to https://github.com/pylint-dev/pylint/issues/9584 which indicate that they agree there's a bug on their side, so I'll merge this now đ Thanks for the review @dhruvmanila!
> Will it be included in Ruff 0.5.0? Just seen this -- unfortunately I just set the release workflow in motion, so unfortunately not. Sorry :-(
Hey @MylesMor â here's a possible way of testing this kind of thing in a GitHub Actions workflow: ```yml jobs: check-pep561-compliance: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 with: path: invoke...
Type definitions created in `if TYPE_CHECKING` blocks obviously won't be available at runtime. If you want to use them elsewhere in the file, you'll either need to quote the definition...
Hmmm https://github.com/mhammond/pywin32/blob/7cac4eb311db157a72edff1968706d92740937ff/Pythonwin/pywin/idle/CallTips.py#L94