muduo icon indicating copy to clipboard operation
muduo copied to clipboard

Any issues or prs are welcome!

Open AlexStocks opened this issue 5 years ago • 6 comments

AlexStocks avatar Aug 31 '19 11:08 AlexStocks

有没有作过性能测试? bug情况如何?

weiwangchao avatar Mar 31 '20 09:03 weiwangchao

有没有作过性能测试? bug情况如何?

项目都是用出来的。欢迎 issue or pr。

AlexStocks avatar Mar 31 '20 10:03 AlexStocks

有没有作过性能测试? bug情况如何?

项目都是用出来的。欢迎 issue or pr。

你自己做过基本测试没? 有没有具体数据?

weiwangchao avatar Mar 31 '20 11:03 weiwangchao

老板, 这个仓库还维护么?

ToaruOsaka avatar Mar 10 '21 06:03 ToaruOsaka

老板, ubuntu20.04 , 执行 ./build.sh buidl all 有一些编译错误, 本地改了改了, 过去了, 如下:

../../../muduo/other/any.h:60:44: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 60 | virtual void static_delete(void** x) { if (*x)

if的大括号作用于,加一组{},过去了

../../..//muduo/net/InetAddress.cc:50: error: "offsetof" redefined [-Werror] 50 | #define offsetof(type, member) __builtin_offsetof(type, member) /usr/lib/gcc/x86_64-linux-gnu/9/include/stddef.h:406: note: this is the location of the previous definition 406 | #define offsetof(TYPE, MEMBER) __builtin_offsetof (TYPE, MEMBER)

加个 #ifndef offsetof, 过去了

../../..//muduo/net/SocketsOps.cc:171:12: error: ‘::readv’ has not been declared; did you mean ‘muduo::net::sockets::readv’? 171 | return ::readv(sockfd, iov, iovcnt);

加个 #include <sys/uio.h>, 过去了

另, 最新的muduo新加了 ./muduo/base/CurrentThread.cc, 您的这个仓库里貌似没有, 囧,大佬, 再更新一把?

ToaruOsaka avatar Mar 10 '21 07:03 ToaruOsaka

@ToaruOsaka pls submit a pr, pls. thx very much.

AlexStocks avatar Mar 11 '21 03:03 AlexStocks