Alex

Results 185 comments of Alex

Eclipse can keep up atm. It's because we didn't perfectly optimize it on our end and that caused trouble. The few people who actually set it to 0 likely have...

I don't think this is our biggest bottleneck at the moment, eclipse traffic is a non-issue now. I think also barely any servers have it set to that and I...

Sounds reasonable, will look into exposing our internal methods.

Please describe your feature request. Why is it needed?

The goal is to move all custom data types such as Knownpack to migrate to NetworkCodec in the future. Right now only KnownPack uses this system. Follow-up PRs will implement...

The main reason for NetworkCodec is to debloat the MinecraftCodecHelper class. It has proven itself to not be a future-proof approach for serializing Minecraft data structures. Using a dedicated codec...

Well I've given benefits of this approach above. Additionally differences in the read/write implementation are far easier to see because they are right next to each other and there is...

Here is an example codebase that makes full use if this concept: https://github.com/SkinsRestorer/SkinsRestorer/blob/dev/shared/src/main/java/net/skinsrestorer/shared/codec/NetworkCodec.java https://github.com/SkinsRestorer/SkinsRestorer/blob/dev/shared/src/main/java/net/skinsrestorer/shared/gui/SRInventory.java

This PR is ready for review. I'm not adding Json Codecs and only NetworkCodec.

The reason why is that I not longer need json Codecs however I still need/want this.