OpenNlp icon indicating copy to clipboard operation
OpenNlp copied to clipboard

Are you going to support this project for net. standard?

Open metatypeman opened this issue 6 years ago • 7 comments

I need library for Net. Core and Mono (Unity 3d).

metatypeman avatar May 15 '18 07:05 metatypeman

Me too!

TobyLobster avatar Jan 29 '19 11:01 TobyLobster

Please, support for .NET Standard 2.0 would be very helpful. I tried invoking this library from a .NET Core unit test project and basic tokenization worked fine. However, the build gives me the warning

Severity	Code	Description	Project	File	Line	Suppression State
Warning	NU1701	Package 'OpenNLP 1.3.4' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. This package may not be fully compatible with your project.	UnitTestProject3Core	

sdg002 avatar Jun 10 '19 13:06 sdg002

I understand your need for .NET standard support but I really don't have time right now. I may have a look at it later this summer. If you need earlier, you can do a pull request.

AlexPoint avatar Jun 10 '19 18:06 AlexPoint

Thank you very much for responding.. I will take a look.

sdg002 avatar Jun 11 '19 07:06 sdg002

Ok. I have cloned your OpenNLP and made an initial attempt. I did an initial conversion of OpenNLP and SharpEntropy to .NET Standard 2.0. I upgraded a couple of other EXE projects to .NET 4.6.1 I must admit that I have made some adhoc changes to get the compilations to work. But, I was able to get the ParseTree EXE to work

image

sdg002 avatar Jun 11 '19 09:06 sdg002

The project SharpEntropy is referencing 2 nuget packages which lack compatibility with .NET Standard 2.0

 warning NU1701: Package 'System.Data.SQLite.EF6 1.0.111' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

 warning NU1701: Package 'System.Data.SQLite.Linq 1.0.111' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.


sdg002 avatar Jun 11 '19 10:06 sdg002

If I remember correctly, SQLlite was used only to write/read GIS models (see OpenNlp/SharpEntropy/SharpentropyLite). It would be better if we could keep it and the first option that comes to my mind is to use .net standard implementation of SQLlite. See https://www.nuget.org/packages/sqlite-net-standard/ Thanks for your help on this!

AlexPoint avatar Jun 11 '19 20:06 AlexPoint