Ice_and_Fire icon indicating copy to clipboard operation
Ice_and_Fire copied to clipboard

[Bug]: IS_OVERWORLD tag added to structure biome generation list for some reason

Open FatCat1978 opened this issue 1 year ago • 0 comments

What happened?

https://github.com/AlexModGuy/Ice_and_Fire/blob/1.20/src/main/java/com/github/alexthe666/iceandfire/datagen/IafBiomeTagGenerator.java

has the IS_OVERWORLD tag applied. This, naturally, fucks up the configs put in place for biome/structure generation if you're not in the overworld, and, overall, smells incredibly bad. you can just use a datapack though, which makes me wonder why the config for that even exists??

Easy way to test it (requires twilight forest, but presumably this would apply to every dim that doesn't use is_overworld)

{ "values": [ "twilightforest:clearing", "twilightforest:lake", "twilightforest:spooky_forest", "twilightforest:forest", "twilightforest:mushroom_forest", "twilightforest:dense_mushroom_forest" ] }

For any structure (I used the gorgon temple because I can't spell mouseyliam), and do /locate with the ice and fire biome tag that enables generation for whatever structure you used.

Features (such as cyclops caves) Are unaffected.

This is doubly weird to me cuz the default config for the structures already requires the is_overworld tag for everything not hardcoded. Probably some nerd reason for it, but in the off chance it's a brain-fart, here it is.

Minecraft Version

1.20.1

Ice and Fire version

2.1.13-1.20.1-beta-4

Citadel version

citadel-2.5.4-1.20.1

Relevant log output

No response

Other Information

  • [X] I am using other mods besides Ice and Fire
  • [ ] I have attached a log file from the session that I have experienced this issue

FatCat1978 avatar Jul 05 '24 00:07 FatCat1978