AlexModGuy
[Bug]: Villagers names on trading tab JEI/REI/EMI are not translated
What happened?
Would be nice to fix this long string name for their proper name.
Minecraft Version
1.20.1
Ice and Fire version
iceandfire 2.1.13-1.20.1+build.beta-2
Citadel version
citadel 2.4.9
Relevant log output
https://mclo.gs/FfzlFk0
Other Information
- [X] I am using other mods besides Ice and Fire
- [X] I have attached a log file from the session that I have experienced this issue
I've looked into this and it seems to only be Just Enough Resources that's not able to properly resolve the translation string. E.g Just enough Professions handles this case fine. (The translation string should be "entity.minecraft.villagers.iceandfire.scribe") I don't see us doing anything different when registering the villager when compared to other mods that add villager professions so I'm unsure about what to do here.
I've looked into this and it seems to only be Just Enough Resources that's not able to properly resolve the translation string. E.g Just enough Professions handles this case fine. (The translation string should be "entity.minecraft.villagers.iceandfire.scribe") I don't see us doing anything different when registering the villager when compared to other mods that add villager professions so I'm unsure about what to do here.
The error I posted was not from JER but EMI trades, and only the scribe is failing the display the name. I am going to ask them if is something on their end.
From what I see, the new translation does not expect the mod id but only the name. As other villagers do follow the expected translation key format (entity.minecraft.villagers.scribe). I feel that JEP uses a hard-coded code as it does not expect a lot of modularity
Can you maybe link a mod that generates the "correct" translation keys? I've looked into some and I don't quite understand why ice and fire would be behaving differently since we seem to be doing exactly the same as some other mods. Maybe I'm missing something obvious though.
A few weeks ago, I had the same problem with Immersive engineering, and they seemed to be able to fix it
https://github.com/BluSunrize/ImmersiveEngineering/issues/5837
https://github.com/BluSunrize/ImmersiveEngineering/commit/1bba77916d1522925b70ced5a5f9b27b3a98e00e
Mods that add custom villagers and have the correct translation: IE: https://legacy.curseforge.com/minecraft/mc-mods/immersive-engineering Ars:https://www.curseforge.com/minecraft/mc-mods/ars-nouveau Universal Saw: https://www.curseforge.com/minecraft/mc-mods/sawmill
Right I see they just duplicated the translation keys. Fair enough. I'll do that then I guess. Thanks :)