exoffice icon indicating copy to clipboard operation
exoffice copied to clipboard

Published 20 hours ago • verified publisher icon AlexKovalevych

Add multiple RK support.

Open Corvimae opened this issue 4 years ago • 6 comments

Adds support for multiple RK blocks. I see there's another PR open for this, but it's so old I figured it was okay to open a new one.

Corvimae avatar Apr 15 '20 14:04 Corvimae

Could you please write a test or provide a test data for such cases?

AlexKovalevych avatar Apr 15 '20 15:04 AlexKovalevych

Done! There was also an issue where shared string tables of length 0 would cause an exception, so I added a guard for that as it was breaking the test.

Corvimae avatar Apr 15 '20 15:04 Corvimae

Are those tests good enough?

Corvimae avatar Apr 17 '20 19:04 Corvimae

Yup, but what's the deal with test_rich_text.xls, why it has changes?

AlexKovalevych avatar Apr 18 '20 11:04 AlexKovalevych

Hmm, I think I might've accidentally marked it as changed. I think it's saying there's nothing different (and the tests still pass), but I can revert that if you're worried.

Corvimae avatar Apr 20 '20 16:04 Corvimae

Revert pls and i'll merge it

AlexKovalevych avatar Apr 20 '20 21:04 AlexKovalevych