WebRTC icon indicating copy to clipboard operation
WebRTC copied to clipboard

Bitcode is now supported in version 57

Open jondwillis opened this issue 7 years ago • 9 comments

./tools-webrtc/ios/build_ios_libs.sh -e !

jondwillis avatar Feb 05 '17 22:02 jondwillis

The compiled framework still doesn't contain bitcode:

/V/H/w/s/out_ios_libs> otool -l WebRTC.framework/WebRTC | grep __LLVM
/V/H/w/s/out_ios_libs>

AlexKMDev avatar Feb 06 '17 01:02 AlexKMDev

Please see http://stackoverflow.com/a/33105733/127422

It indeed does contain bitcode :) I am able to use my build of latest WebRTC master with bitcode enabled in my app.

otool -arch armv7 -l WebRTC.framework/WebRTC | grep LLVM    
  segname __LLVM
  segname __LLVM

jondwillis avatar Feb 06 '17 07:02 jondwillis

We should update the README if this gets applied and verified.

jondwillis avatar Feb 06 '17 07:02 jondwillis

Are you getting a 700MB library when compiled bitcode ON ?

antoniotuzzi avatar Feb 06 '17 18:02 antoniotuzzi

@antoniotuzzi Yeah, trying to figure out why.

jondwillis avatar Feb 06 '17 18:02 jondwillis

@jondwillis compiled static is 776MB must be related to the huge number of .obj linked: the bitcode should be doing very strange tricky things with this sizes is impossibile to distribute in an SDK anyway, when compiled in a final product, or intermediate library, size decrease A LOT

antoniotuzzi avatar Feb 06 '17 18:02 antoniotuzzi

@antoniotuzzi I have noted the large framework size in https://bugs.chromium.org/p/webrtc/issues/detail?id=5085&can=2&start=0&num=100&q=&colspec=ID%20Pri%20M%20ReleaseBlock%20Component%20Status%20Owner%20Summary&groupby=&sort=

I will update here if there is an answer.

jondwillis avatar Feb 06 '17 19:02 jondwillis

I don't like bitcode, hard to manage dSYMs for little benefits

wenxin3262 avatar Feb 07 '17 05:02 wenxin3262

Bitcode doesnt change anything on symbolification of crash logs. apples / testflight gives you the correct dsyms if they recompile form source.

fuxx avatar May 19 '17 13:05 fuxx