Crash with Vanilla Hammers

[Imsvale]

https://www.curseforge.com/minecraft/mc-mods/vanilla-hammers

Note that as I'm porting BuildCraft to fabric/1.15 I won't be updating or improving this very much.

So I don't know if this will be interesting to you, but these two mods together causes crashes. Once I identified the culprit mods, I created a new clean instance with only these two mods (and whatever dependencies GDLauncher throws in for Fabric).

Steps:

• New world
• Make and Equip a hammer from Vanilla Hammers
• Get close to, I believe, any block that interacts with the hammers' 3x3 mining ability (e.g. stone/cobblestone/furnace)
• The game will now crash, and crash again on loading into the world until either mod is disabled:
  • Disabling Vanilla Hammers resolves the crashing, obviously, as it removes all hammers in the game.
  • Disabling SimplePipes resolves the crashing and allows you to use the hammers normally.

There are some details I haven't worked out on how close you can get in what direction, but that was more for my own curiosity. I reckon this is sufficient for the report. Also you can stand on a block that is adjacent (-1 X/Z) to a furnace, but as soon as you look at the furnace, you will also crash, so it's not just proximity.

crash-2021-03-03_23.08.56-client.txt crash-2021-03-04_00.35.28-client.txt

If you figure it out, I'd be curious for a short description of what it was that interacted between the two mods that made it crash. It just seems like such a strange interaction. Vanilla Hammers doing its thing, minding its own business, trying to 3x3 mine some stuff, and a random pipe mod steps in when there aren't even any pipes anywhere in the world, let alone pipes close to the player. Or maybe it's the library you're testing. ^^

[AlexIIL]

Likely caused by LMP's 0.4.7 update, also reported here: https://github.com/AlexIIL/LibMultiPart/issues/26.

This is related to https://github.com/AlexIIL/LibMultiPart/pull/24#issuecomment-780280499 (and also probably crashes with the Staff of Building mod).

[AlexIIL]

(Don't worry I still fix crashes - just anything else is unlikely)

[AlexIIL]

Okay, this should be fixed in 0.5.0-pre.1, although I'll release it properly tomorrow.

[Imsvale]

Thanks man!