LibMultiPart icon indicating copy to clipboard operation
LibMultiPart copied to clipboard

Published 20 hours ago • verified publisher icon AlexIIL

Mixin incompatibility with MoreCulling

Open Juuxel opened this issue 3 years ago • 1 comments

See Juuxel/VanillaParts#29 for the crash log. The issue is basically that MoreCulling @Overwrites Block.shouldDrawSide while LMP tries to inject into it:

https://github.com/AlexIIL/LibMultiPart/blob/211acc9a18aa04f0f2de082320b22504dd55f2d0/src/main/java/alexiil/mc/lib/multipart/mixin/impl/Client_BlockMixin.java#L29-L35

Juuxel avatar Jun 08 '22 10:06 Juuxel

Currently, this will no longer crash, although LibMultiPart will not cull multiparts correctly. ~~Once the 1.19 branch is ready, I can add MoreCulling compatibility to it~~

FxMorin avatar Jul 16 '22 18:07 FxMorin