tcc-g15 icon indicating copy to clipboard operation
tcc-g15 copied to clipboard

add global hotkeys to change Gmode&&add plot widget

Open AprDeci opened this issue 1 year ago • 5 comments

Added a global hotkey (tested with G15 5511's G key) to quickly switch G modes Added a plot widget which could mouse interactive to change the curve(I haven't written any code about temperature control in the main program yet)

AprDeci avatar Aug 28 '24 01:08 AprDeci

I also add a window toast to show the current mode switching

AprDeci avatar Aug 28 '24 02:08 AprDeci

The plot widget will conflict with your slider widget. If you are willing to merge my PR, I want to know what you think of the conflict

AprDeci avatar Aug 31 '24 07:08 AprDeci

Hi! Thank you for the contribution! After a read through the proposed changes, I cannot directly accept the PR due to some technical problems with the code, but I will review / make changes and will credit you as the commit co-author when I merge to the main branch. Very nice work overall.

AlexIII avatar Sep 15 '24 13:09 AlexIII

Hi! Thank you for the contribution! After reviewing the proposed changes, I cannot directly accept the PR due to some technical issues with the code, but I will review/make changes and will credit you as the commit co-author when I merge to the main branch. Very nice work overall.

Thanks for your reply, I'm not a professional Python developer,so I absolutely agree you to change the code(I also think my code is not good)

AprDeci avatar Sep 15 '24 13:09 AprDeci

Parts of this PR (support for G mode hotkey) were included in 1.6.0 release. Your contribution is reflected in #786fbc4 and #d606fe3 https://github.com/AlexIII/tcc-g15/commits/master/ I will review the remaining functionality (fan curves) a bit later.

AlexIII avatar Sep 16 '24 10:09 AlexIII