cordova-splash icon indicating copy to clipboard operation
cordova-splash copied to clipboard
verified publisher icon AlexDisler

Added iOS storyboard support, including --use-storyboard-singular=true

Open john-doherty opened this issue 7 years ago • 5 comments

  • Merged previous iOS storyboard support, but disabled legacy image generation when in storyboard mode
  • Added --use-storyboard-singular=true switch to generate a singular storyboard image which reduces the overall app size
  • Updated README to reflect changes

john-doherty avatar Apr 10 '18 11:04 john-doherty

Do I have to add any settings to config.xml to use the iOS storyboard?

luxio avatar May 15 '18 11:05 luxio

@AlexDisler when merge this to master branch?

catalsdevelop avatar Jun 07 '18 04:06 catalsdevelop

👍

ISNIT0 avatar Nov 02 '18 14:11 ISNIT0

It would be great to get this merged. I can see there is a conflict but I am unable to resolve it as I don't have write access... Anyone needing this version can install via:

npm install -g john-doherty/cordova-splash

john-doherty avatar Mar 21 '19 15:03 john-doherty

Hi @john-doherty. Thanks for this. I have installed your version and it works nicely. But the images generated in Images.xcassets/LaunchStoryboard.imageset seem to be ignored. The images in Images.xcassets/LaunchImage.launchimage are used instead. And in Xcode I see the following warning:

"The image set "LaunchStoryboard" has an unassigned child."

This turns out to be the generated Default@2x~universal~anyany.png (--use-storyboard-singular=true).

So it seems to me that there must be more to getting this to work than I expected. The Contents.json file seems to need updating. And I am not sure what to do in order to fully replace legacy launch images with the storyboard image(s). When I tried simply deleting Images.xcassets/LaunchImage.launchimage the Cordova/Xcode build failed.

Thoughts?

daffinm avatar May 09 '19 14:05 daffinm