Alex Cheema
Alex Cheema
This is awesome! First proper PR, congrats! Code looks great, only one very minor thing for consistency across the codebase, instead of `platform` use `psutil`. It's the same thing but...
Also don't we need to add `netifaces` as a dependency in `setup.py`?
Just added an [integration test for discovery](https://github.com/exo-explore/exo/actions/runs/10018442725/job/27693811593). Already coming in useful, we'll see if it still passes after your changes.
I just quickly tested this myself locally. For me, the interface name does not begin with `thunderbolt`. ```python # before thunderbolt connected >>> netifaces.interfaces() ['lo0', 'gif0', 'stf0', 'anpi0', 'anpi1', 'anpi2',...
Eventually we should support automatically upgrading to the best interface available (in this case thunderbolt) - see #51. We can implement this later though, for now this is great.
Just to clarify, this still needs to be fixed / tested: https://github.com/exo-explore/exo/pull/47#issuecomment-2241334740
Have you got a thunderbolt cable to test this with? I don't think this works in its current state. This is what `system_profiler SPNetworkDataType -json` gives me for my MacBook...
I had another look and generally I don't think this is doing what we want it to do. I'm not even sure the behaviour is different to before the changes....
> Did: > > * A `priority` field is added to the broadcast message. > * Modified `known_peers` to include the priority info. > * Implemented reconnection logic in `on_listen_message`...
@itsknk First of all, thanks a lot for these contributions - experimentation helps a lot to inform future decisions even if things don't get merged. I end up throwing away...