obsidian-better-command-palette icon indicating copy to clipboard operation
obsidian-better-command-palette copied to clipboard

Turned on "strict" in tsconfig

Open johnw42 opened this issue 1 year ago • 1 comments

This PR turns on "strict" in tsconfig.json and fixes the resulting type errors, mostly by adding the "!" character to assert that values are non-null and member variables are initialized before they are used, based on the assumption that the existing code is correct.

It also fixes a bunch of eslint errors and re-enables eslint in rollup.config.js.

johnw42 avatar Oct 04 '23 03:10 johnw42

It seems I accidentally turned my last PR into a no-op, so here it is again.

I also encountered a bunch of eslint errors that weren't there before and discovered that eslint got turned off in the rollup config, so I fixed those problems, too. I'm not sure how that happened unless maybe you updated your master branch after I created my first PR. Anyway, it's fixed now.

johnw42 avatar Oct 04 '23 03:10 johnw42