AlexBVolcy
AlexBVolcy
For future reference, can you not force push as it squashes the commits from the past making it harder to review. Thank you!
@zhongshixi Hey! Just checking in on the status of this PR? I want to be clear that the code coverage comments that I left aren't critical to be implemented for...
I'm seeing test failures within `executor_test.go`, here are the following tests that are failling: `TestExecuteEntrypointStage,` `TestExectureRawAuctionStage,` `TestExecuteAuctionResponseStage,` `TestExecuteAllProcessedBidResponsesStage`, `TestExecuteRawBidderResponseStage,` `TestExecuteBidderRequestStage,` `TestExecuteProcessedAuctionStage` Can you look into this?
@ShriprasadM Just pinging this PR to see if you'll be able to address my comments
@ShriprasadM just pinging to see if you've seen the above comments made? And if you could merge with master to fix conflicts that'd be great!
Upgrade Bid Adjustments was developed and merged. Here is the merged PR: https://github.com/prebid/prebid-server/pull/2678