orbital-qemu icon indicating copy to clipboard operation
orbital-qemu copied to clipboard

Published 20 hours ago • verified publisher icon AlexAltea

Fix linux build issues

Open MasonLeeBack opened this issue 6 years ago • 2 comments

MasonLeeBack avatar Dec 12 '18 15:12 MasonLeeBack

This fixes compatibility using older versions of libzip (newer ones aren't provided on stock ubuntu package lists) and fixes an issue with a Windows-only macro.

MasonLeeBack avatar Dec 12 '18 15:12 MasonLeeBack

Just a suggestion: In orbital.c, can you replace ARRAYSIZE with IM_ARRAYSIZE and in vk-helpers.c replace it with countof? That way there's no need to define yet another way of doing the exact same thing.

Then just amend the current commit and I'll merge it.

AlexAltea avatar Dec 12 '18 15:12 AlexAltea