thorium icon indicating copy to clipboard operation
thorium copied to clipboard

Th24 looks ugly when using some custom themes

Open dnchshrp opened this issue 1 year ago • 5 comments

System Details

Problem There are visible white lines that appear when using custom themes which makes the UI look ugly: image image image image

It also would be nice to be able to optionally make the tab separators invisible since they can look bad in some cases: image

Did you read the FAQ? Yes

Additional Notes

dnchshrp avatar Oct 26 '24 09:10 dnchshrp

Currently, th24 styles should only be adapted to the default theme.

gz83 avatar Oct 26 '24 09:10 gz83

@gz83 @dnchshrp I can fix the white line outline on the omnibox. The white line under the bookmarks bar, im not sure what that is or why its doing that.

The tab separators are not an issue (from a code perspective): they are behaving normally. Installing this theme on Chrome should also make the separators look like that. Removing the separators would fuck spacing up to no end, however, I might put a flag that tells them to be 0 opacity i.e. transparent to the color on the layer underneath it. The problem is that means yet another command line code path to maintain, just for you or the few that encounter this.

While I want everyone to enjoy thorium, and I am definitely not above taking the time to fix something just for one person, I also have to balance how many times I do stuff like that. I am thinking this should be easy, so I can probably do it for you, but no promises, because if it takes above a certain amount of time or requires modifying too many files, I won't be able to justify it in my head

Alex313031 avatar Oct 29 '24 02:10 Alex313031

OK, thanks for the response! @Alex313031

dnchshrp avatar Oct 29 '24 14:10 dnchshrp

@gz83 Yes, but the ultimate goal is to have Th24 work seamlessly, meaning that themes should also work. The only thing I have no idea about is the whole bookmarks bar white line thing.

Alex313031 avatar Oct 31 '24 03:10 Alex313031

Image

I can confirm that when I activate th24 ui I have the same problem with that line, which is not white but transparent, what you see is the desktop below.

EDIT1: if you drag the window a little, the line turns gray (I think it's a simple separator). If you place a window in front of Thorium it still stays gray, unless you use a full-screen window, which covers all of Thorium window, in which case when you bring it back to the foreground the line becomes transparent again.

EDIT2: The issue is related to the bookmarks bar, if you disable it the problem disappears. Also it only happens if the bookmark bar is empty, if you have at least one bookmark saved the problem does not happen.

I am on Debian 12 Linux with XFCE.

deviato avatar Apr 18 '25 07:04 deviato