thorium icon indicating copy to clipboard operation
thorium copied to clipboard

Upgrade from 124 to 126 causes crash depending on Preferences

Open Thulinma opened this issue 1 year ago • 3 comments

System Details

  • OS: Arch
  • Thorium Version 126.0.6478.231

Problem Upgrading from 124.X to 126.X causes a crash on boot if the Preferences file in the profile contains the string "theme":{"id":"","system_theme":1}, inside the extensions object. I'm guessing this is the setting that controls the experimental Thorium theme, which I had enabled in 124. Removing the string from the Preferences file causes the upgrade to succeed without further problems.

Additional Notes Mostly putting this here so it can hopefully be automatically fixed in future releases, or at least so that others running into the same problem can find it and know how to solve it without needing to debug for a few hours like I ended up doing. 🙃

Thulinma avatar Sep 22 '24 21:09 Thulinma

@Thulinma This is not the reason for the crash, but you're close. Thanks for letting me know, as I was wondering if the code change would cause crashes on other systems.

Also, what experimental thorium theme in M124 are you talking about.

Alex313031 avatar Sep 27 '24 21:09 Alex313031

Ah yes, it was just a guess. Glad that you know what it is, at least! 👍

I.... don't recall what exact release had this, but some releases ago there was a theme of some sort mentioned in the "Thorium Experiments". I only noticed it was gone in the latest version but that may have actually disappeared much longer ago. I don't check the experiments list all that often. Sorry for any confusion! 😅

Thulinma avatar Sep 27 '24 23:09 Thulinma

@Thulinma I think I fixed this here > https://github.com/Alex313031/thorium/commit/5b41ddba80b220e63ceb51c69466aa67488f25e9

Alex313031 avatar Sep 30 '24 22:09 Alex313031