Alex Vasile
Alex Vasile
> 1. ~~Equal/hash fixes in inherited classes~~, docs about it. > > 2. Research color depended code in ManaOptions usage (is it exists); > > 3. Additional test for ConditionalMana;...
> Possible research/idea: use standard lib to work with a combinations data (see google's guava lib). We can open a separate issue into this (seeing if there is a library...
> * ~Equal/hash fixes in inherited classes~, docs about it. > * Research color depended code in ManaOptions usage (is it exists); > * Additional test for ConditionalMana; I plan...
> @Alex-Vasile do not merge active PRs until active discussion/research finish (it's a bad thing and goes to unstable/unfinished code and technical debt, see your use case with auto-choices in...
Okay. I think I have addressed all of the concerns from before. Instead of removing `getPossiblePayCombinations` I tried implementing a more efficient version of it but ultimately couldn't get it...
I plan to merge this at the end of the week unless any issues can be found with it
The bug was fixed in deb29c0659336b7df407a7696fd88a7a1360d531. But the test can still be added, can you merge in from main to address the conflict from deb29c0659336b7df407a7696fd88a7a1360d531.
You are correct. It should deal 5 damage. Is it just the coping that doesn't work, or is it other non-foretell exile casts? (e.g. [[Prosper, Tome-Bound]])
From the log: ``` java.lang.OutOfMemoryError: GC overhead limit exceeded at java.util.HashMap.newNode(HashMap.java:1774) at java.util.HashMap.putVal(HashMap.java:632) at java.util.HashMap.put(HashMap.java:613) at mage.abilities.effects.EffectImpl.(EffectImpl.java:46) at mage.abilities.effects.OneShotEffect.(OneShotEffect.java:20) at mage.abilities.effects.common.CreateTokenEffect.(CreateTokenEffect.java:60) at mage.abilities.effects.common.CreateTokenEffect.copy(CreateTokenEffect.java:71) at mage.abilities.effects.common.CreateTokenEffect.copy(CreateTokenEffect.java:25) at mage.abilities.effects.Effects.(Effects.java:23) at mage.abilities.effects.Effects.copy(Effects.java:28) at...
So the memory issue is cased by two things: 1. Each time an ability is put on the stack, it's rules text is re-generated. - This puts a lot of...