Cookies-EU-banner icon indicating copy to clipboard operation
Cookies-EU-banner copied to clipboard

Published 20 hours ago • verified publisher icon Alex-D

Replace inline style by hidden attribute...

Open robsonsobral opened this issue 2 years ago • 7 comments

...in a retro compatible way

closes #48

robsonsobral avatar Mar 21 '22 15:03 robsonsobral

Rethinking... My code is retro-compatible only in case the style is set inline. I guess I should change it.

robsonsobral avatar Mar 22 '22 02:03 robsonsobral

FIXED.

robsonsobral avatar Mar 22 '22 02:03 robsonsobral

I think I can drop IE8 support now and use classList

Are you sure? Move to v3 just because of that? No adding tests? I guess we could, at least, add code linting. Of course, keeping the simplicity and the small size.

dataset is also IE10+

robsonsobral avatar Mar 22 '22 12:03 robsonsobral

I will take some time to clean that with my eslint ruleset

IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something?

Alex-D avatar Mar 22 '22 13:03 Alex-D

I will take some time to clean that with my eslint ruleset

Let's use Airbnb! It's a standard.

IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something?

Changes of support are MAJOR, but as that's already done on v2, I guess we can just update the README.

I wouldn't reduce support for things so simple to resolve, but you're the boss!

robsonsobral avatar Mar 22 '22 14:03 robsonsobral

We could move to ESBuild as well.

robsonsobral avatar Mar 22 '22 14:03 robsonsobral

The constant of the world is to change, @Alex-D .

https://github.com/WICG/display-locking/blob/main/explainers/hidden-content-explainer.md

robsonsobral avatar Mar 24 '22 15:03 robsonsobral