Alessandro Patti

Results 20 comments of Alessandro Patti

Thanks @ulrfa I added a small benchmark in https://github.com/buchgr/bazel-remote/pull/695/commits/420f4adedbce4c654bce8d302ca92c76bad055b3 that seems to somewhat confirm what you've experienced. Increasing the go routines does not make it worse but doesn't make it...

What are your concerns? There's a benchmark that can be run with `bazel run cache/hashing:go_default_test -- --test.bench .`, I'll include my results here: Linux x86_64 ``` goos: linux goarch: amd64...

@mostynb I've seen most improvements for targets that produce large files, like deployables (fat jars or binaries, docker images). If you can suggest one or two OSS projects to test...

@jackwellsxyz @mostynb sorry, I've been busy and I did not get around to run any test. I'll try to find some time in the next few days.

Sorry, this took longer than expected. I tried testing it a bit with bazel itself as @mostynb suggested and did not notice substantial difference (just 1-2% faster). I tested both...

@mostynb do you think we can land this change to support other digest functions?

@mostynb did you get around to review this? Would love to hear your feedback to get this to a mergable state

Wonder if this is also fixed by https://github.com/bazelbuild/rules_go/pull/4009

@coeuvre opinions? @tjgq I think one reason to have the flag is the file size: not all users are interested in the configuration (only useful if there's a significant enough...

For us, increasing the OS limit did help. My understanding is that there are two main sources of go routines: evictions and requests. Improving the evictions might help towards the...