postcss-sass Extended a parser class

Extended a parser class

Open maletsden opened this issue 6 years ago • 7 comments

Added supporting of @media, @mixin, @include, @extend, loops(@while, @for, @each)

Jun 17 '18 11:06 maletsden

Hey, @maletsden. Thanks, for PR. Please fix linter errors, before I'll review it. Thanks!

Jun 17 '18 22:06 AleshaOleg

@maletsden thanks, I'll add now lint-staged to prevent errors on commit steps.

Jun 17 '18 22:06 AleshaOleg

@maletsden there're some errors still left. Check this - https://travis-ci.org/AleshaOleg/postcss-sass/jobs/393425991#L1232

Jun 17 '18 22:06 AleshaOleg

Also, I will write tests for this methods a bit later. Ok?

Jun 17 '18 23:06 maletsden

@maletsden that's totally fine, but after your last changes tests failing:(

Jun 17 '18 23:06 AleshaOleg

That's most likely because I've changed loop method since It wasn't working properly(it was slicing a part of parameters of loop node)

Jun 17 '18 23:06 maletsden

@maletsden ok, I'll check later

Jun 17 '18 23:06 AleshaOleg