PySUS icon indicating copy to clipboard operation
PySUS copied to clipboard

Refactor FTP operations to a single function

Open fccoelho opened this issue 4 years ago • 3 comments

Many of our modules replicate basic ftp file retrieval operations We should remove all the duplication of code by creating a single function for retrieving files through FTP. this function should most likely belong to an ftptools module in the utilities package.

fccoelho avatar Nov 05 '21 08:11 fccoelho

Is this issue still valid?

anapaulagomes avatar Jul 31 '24 06:07 anapaulagomes

Thanks for asking. I don't think so. @luabida has done a big refactoring of the FTP interface. @luabida, can we close this one as stale?

fccoelho avatar Jul 31 '24 11:07 fccoelho

Thanks for asking. I don't think so. @luabida has done a big refactoring of the FTP interface. @luabida, can we close this one as stale?

I guess so. This is the only method responsible for accessing the DATASUS ftp server after the refactor, any special error cases should be handled in its try except block. Currently, the purpose of the try block is to close the ftp connection if any error happen

luabida avatar Jul 31 '24 21:07 luabida