snarkVM icon indicating copy to clipboard operation
snarkVM copied to clipboard

Use Zero and One from num_traits

Open kobigurk opened this issue 5 years ago • 2 comments

As described in https://github.com/AleoHQ/snarkOS/pull/219:

https://github.com/scipr-lab/zexe/ uses the Zero and One traits from the num_traits crate. Due to a trait resolution problem in Rust, the Add trait that the num_traits traits add to each implementer of Zero and One makes the current Add<&'a Self> unusable. While it seems like a good idea to do the same as Zexe, it requires wide code-base changes and so I'll leave that for a future PR. The traits introduced here are a version of the num_traits traits without the additional Add constraint.

kobigurk avatar Jun 15 '20 08:06 kobigurk

Team, is this something we want to do?

damons avatar May 25 '21 17:05 damons

Moving to snarkVM in case it's still desired.

ljedrz avatar Sep 21 '21 10:09 ljedrz